fix(default.gbui): Removed warnings from code.

GeneralBots · Jun 13, 2021 · d742c00 · d742c00
1 parent 42719e7
commit d742c00
Show file tree

Hide file tree

Showing 9 changed files with 191 additions and 290 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -107,7 +107,7 @@
     "speakingurl": "^14.0.1",
     "sppull": "2.7.0",
     "strict-password-generator": "1.1.2",
-    "swagger-client": "2.1.18",
+    "swagger-client": "^3.13.5",
     "tedious": "9.2.1",
     "textract": "2.5.0",
     "typescript": "4.3.2",

diff --git a/packages/default.gbui/src/GBUIApp.js b/packages/default.gbui/src/GBUIApp.js
@@ -72,7 +72,6 @@ class GBUIApp extends React.Component {
         })
         .subscribe(() => {
           window.userAgentApplication.logout();
-          console.log('updateToken done');
         });
     }, 400);
   }
@@ -86,8 +85,7 @@ class GBUIApp extends React.Component {
         textFormat: 'plain',
         timestamp: new Date().toISOString(),
         from: this.getUser()
-      })
-      .subscribe(console.log('EVENT SENT TO Guaribas.'));
+      });
   }
 
   getUser() {
@@ -106,7 +104,6 @@ class GBUIApp extends React.Component {
         timestamp: new Date().toISOString(),
         from: window.user
       })
-        .subscribe(console.log("success"));
     }, 400);
   }
   postMessage(value) {
@@ -156,9 +153,9 @@ class GBUIApp extends React.Component {
     let userAgentApplication = new UserAgentApplication(
       this.state.instanceClient.authenticatorClientId,
       authority,
-      function (errorDesc, token, error, tokenType) {
+      function (errorDesc, token, error) {
         if (error) {
-          console.log(error);
+          _this_.sendToken(error);
         }
       }
     );
@@ -173,7 +170,7 @@ class GBUIApp extends React.Component {
             _this_.sendToken(accessToken);
           },
           function (error) {
-            console.log(error);
+            _this_.sendToken(error);
           }
         );
       }
@@ -200,14 +197,14 @@ class GBUIApp extends React.Component {
 
     line.activity$
     .filter(activity => activity.type === 'event' && activity.name === 'loadInstance')
-    .subscribe(activity => {
+    .subscribe(() => {
       this.postEvent('startGB', true);
       _this_.authenticate();
     });
 
   line.activity$
       .filter(activity => activity.type === 'event' && activity.name === 'stop')
-      .subscribe(activity => {
+      .subscribe(() => {
         if (_this_.player) {
           _this_.player.stop();
         }
@@ -301,7 +298,7 @@ class GBUIApp extends React.Component {
           );
           break;
         default:
-          console.log('GBERROR: Unknow player type specified on message from server.');
+          playerComponent = <div>GBERROR: Unknow player type specified on message from server.</div>;
           break;
       }
     }

diff --git a/packages/default.gbui/src/components/SidebarMenu.js b/packages/default.gbui/src/components/SidebarMenu.js
@@ -42,8 +42,7 @@ class SideBarMenu extends React.Component {
         textFormat: "plain",
         timestamp: new Date().toISOString(),
         from: window.user
-      })
-      .subscribe(console.log("success"));
+      });
   }
 
   render() {

diff --git a/packages/default.gbui/src/players/GBBulletPlayer.js b/packages/default.gbui/src/players/GBBulletPlayer.js
@@ -46,14 +46,13 @@ class RenderItem extends Component {
         timestamp: new Date().toISOString(),
         from: window.user
       })
-      .subscribe(console.log("success"));
     },400);
   }
 
   render() {
     return (
       <ul>
-        {this.props.list.map((item, i) => (
+        {this.props.list.map((item) => (
           <li key={item.questionId}>
             <label className="gb-bullet-player-item" onClick={this.send.bind(this, item)}>{item.content}</label>
           </li>

diff --git a/packages/default.gbui/src/players/GBImagePlayer.js b/packages/default.gbui/src/players/GBImagePlayer.js
@@ -46,7 +46,7 @@ class GBImagePlayer extends Component {
   stop(){
     this.playerImage.src = "";
   }
-  componentDidUpdate(prevProps, prevState) {}
+
 
   render() {
     return (

diff --git a/packages/default.gbui/src/players/GBLoginPlayer.js b/packages/default.gbui/src/players/GBLoginPlayer.js
@@ -41,7 +41,7 @@ class GBLoginPlayer extends React.Component {
     };
   }
 
-  doLogin(info) {
+  doLogin() {
     let authority =
       "https://login.microsoftonline.com/" +
       this.state.login.authenticatorTenant;
@@ -51,9 +51,9 @@ class GBLoginPlayer extends React.Component {
     let userAgentApplication = new UserAgentApplication(
       this.state.login.authenticatorClientId,
       authority,
-      function (errorDesc, token, error, tokenType) {
+      function (errorDesc, token, error) {
         if (error) {
-          console.log(error);
+          this.setState({ login: error});
         }
       })
 

diff --git a/packages/default.gbui/src/players/GBMarkdownPlayer.js b/packages/default.gbui/src/players/GBMarkdownPlayer.js
@@ -46,7 +46,6 @@ class GBMarkdownPlayer extends Component {
           timestamp: new Date().toISOString(),
           from: { id: "webUser", name: "You" }
         })
-        .subscribe(console.log("success"));
     }, 400);
   }
 
@@ -62,7 +61,6 @@ class GBMarkdownPlayer extends Component {
           timestamp: new Date().toISOString(),
           from: window.user
         })
-        .subscribe(console.log("success"));
     }, 400);
 
   }

diff --git a/packages/default.gbui/src/players/GBPowerBIPlayer.js-dont-work-now b/packages/default.gbui/src/players/GBPowerBIPlayer.js-dont-work-now
@@ -47,7 +47,6 @@ class GBPowerBIPlayer extends Component {
           timestamp: new Date().toISOString(),
           from: { id: "webUser", name: "You" }
         })
-        .subscribe(console.log("success"));
     }, 400);
   }