Push socklist detection through to main by cherry-picking commits #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the socklist template. See https://en.wikipedia.org/wiki/Template_talk:SPI_report#Proposed_change_to_sock_list
Fixing unnamedParameterRegex per #99 (comment)
|
The failing check in eslint is due to code already in the main version of spihelper and is a complaint about an unused variable. This might be worth fixing, but as this patch is meant to be a hotfix it could always wait (as it has no effect on the running of spihelper anyway). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://en.wikipedia.org/wiki/Template_talk:SPI_report#Proposed_change_to_sock_list the socklist template is going to be used in Twinkle. The patch is at wikimedia-gadgets/twinkle#1509 and has been merged into source. All that is from it being used on enwiki is a deployment. Because of this, and because there is discussion about changing the preload form to use socklist soon, the changes to support the socklist in -dev should be merged into main soon so that those using the main version of spihelper do have their version break.
This pull request has cherry-picked the relevant commits from the develop branch so that only the socklist detection code is a part of this pull request. I have tested the code currently in Dreamy-Jazz/main (which contains the cherry-picked commits) to ensure the socklist code works with the older version of spihelper and my testing brought no errors.