SAC-12 Category RUD #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettladley
requested review from
a team,
sunnyh2024 and
edwinliiiii
and removed request for
a team
garrettladley
requested review from
DOOduneye and
garrettladley
and removed request for
a team
backend/src/services/category.go
Outdated
| CreateCategory(category models.Category) (*models.Category, error) | ||
| } | ||
| CreateCategory(category models.CreateUpdateCategoryRequestBody) (*models.Category, error) | ||
| GetCategories() (*[]models.Category, error) |
There was a problem hiding this comment.
Suggested change
| GetCategories() (*[]models.Category, error) | |
| GetCategories() ([]models.Category, error) |
for consistency, let's return an empty slice instead of a nil pointer. Agreed @DOOduneye ?
garrettladley
requested changes
Jan 22, 2024
|
also CI seems to be failing |
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request handles the remaining CRUD logic for the Category entity (RUD)
How Has This Been Tested?
A complete test suite has been written in category_test under the tests directory.
Checklist