Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAC-19 User Tag CRUD #67

Merged
merged 20 commits into from
Jan 27, 2024
Merged

SAC-19 User Tag CRUD #67

merged 20 commits into from
Jan 27, 2024

Conversation

alderwhiteford
Copy link
Collaborator

@alderwhiteford alderwhiteford commented Jan 26, 2024 •
edited
Loading

Description

Additional Endpoints to Create and Retrieve user tags

How Has This Been Tested?

Tests still need to be written

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@alderwhiteford alderwhiteford marked this pull request as ready for review January 27, 2024 21:30
@garrettladley garrettladley self-requested a review January 27, 2024 23:11
garrettladley
garrettladley requested changes Jan 27, 2024
View reviewed changes
backend/src/services/user.go Outdated Show resolved Hide resolved
backend/src/services/user.go Outdated Show resolved Hide resolved
backend/tests/api/user_test.go Outdated Show resolved Hide resolved
backend/tests/api/user_test.go Outdated Show resolved Hide resolved
backend/tests/api/user_test.go Outdated Show resolved Hide resolved
Alder Whiteford and others added 6 commits January 27, 2024 18:16
SAC-19 Break-up test
e201bd2
Merge branch 'SAC-19-User-Tag-CRUD' of https://github.com/GenerateNU/sac
95eebb0 
 into SAC-19-User-Tag-CRUD
@alderwhiteford @garrettladley
Update backend/src/services/user.go
d3ac869 
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
@alderwhiteford @garrettladley
Update backend/src/services/user.go
94a099d 
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
@alderwhiteford @garrettladley
Update backend/tests/api/user_test.go
5b2dce8 
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
@alderwhiteford @garrettladley
Update backend/tests/api/user_test.go
1eb532f 
Co-authored-by: Garrett Ladley <92384606+garrettladley@users.noreply.github.com>
garrettladley
garrettladley approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@garrettladley garrettladley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📈

@garrettladley garrettladley merged commit cdb8d11 into main Jan 27, 2024
7 checks passed
@garrettladley garrettladley deleted the SAC-19-User-Tag-CRUD branch January 27, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettladley garrettladley garrettladley approved these changes

Assignees

@alderwhiteford alderwhiteford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alderwhiteford @garrettladley