Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LP Interface #36

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

trmid
Copy link
Member

@trmid trmid commented Sep 25, 2023

No description provided.

@linear
Copy link

linear bot commented Sep 25, 2023

GEN-633 Allow Liquidation Pairs to be discoverable

To check if a liquidationPair is active, a bot must check if the liquidationPair's source points back to it, but there is no standard for this.

  • Add to ILiquidationSource the fxn isLiquidationPair(address tokenOut, address liquidationPair) to determine whether liquidation pair is valid (so we can verify)
  • Add an event to ILiquidationSource that must be emitted when a liquidation pair is set (so we can index)

@github-actions
Copy link

LCOV of commit 30a1087 during 100% Test Coverage #162

Summary coverage rate:
  lines......: 100.0% (140 of 140 lines)
  functions..: 100.0% (29 of 29 functions)
  branches...: no data found

Files changed coverage rate: n/a

@trmid trmid merged commit 02d4221 into main Sep 27, 2023
2 checks passed
@trmid trmid deleted the gen-633-allow-liquidation-pairs-to-be-discoverable branch September 27, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants