Merge pull request #19 from GenerationSoftware/gen-264-c4-issue-311

Gen 264 c4 issue 311
GenerationSoftware · Aug 15, 2023 · df65097 · df65097
2 parents f3b5a57 + c624ffc
commit df65097
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/.gitmodules b/.gitmodules
@@ -19,3 +19,6 @@
 [submodule "lib/ring-buffer-lib"]
 	path = lib/ring-buffer-lib
 	url = https://github.com/GenerationSoftware/ring-buffer-lib
+[submodule "lib/uniform-random-number"]
+	path = lib/uniform-random-number
+	url = https://github.com/generationsoftware/uniform-random-number
diff --git a/lib/uniform-random-number b/lib/uniform-random-number
diff --git a/remappings.txt b/remappings.txt
@@ -4,3 +4,4 @@ openzeppelin=lib/openzeppelin-contracts/contracts/
 pt-v5-twab-controller/=lib/pt-v5-twab-controller/src/
 ring-buffer-lib/=lib/ring-buffer-lib/src/
 owner-manager-contracts/=lib/owner-manager-contracts/contracts/
+uniform-random-number/=lib/uniform-random-number/src/
diff --git a/src/libraries/TierCalculationLib.sol b/src/libraries/TierCalculationLib.sol
@@ -2,6 +2,7 @@
 
 pragma solidity ^0.8.19;
 
+import { UniformRandomNumber } from "uniform-random-number/UniformRandomNumber.sol";
 import { E, SD59x18, sd, unwrap, convert, ceil } from "prb-math/SD59x18.sol";
 import { UD60x18, convert as convertUD60x18 } from "prb-math/UD60x18.sol";
 
@@ -89,7 +90,7 @@ library TierCalculationLib {
                 - Portion of prize that was contributed by the vault
         */
     // first constrain the random number to be within the vault total supply
-    uint256 constrainedRandomNumber = _userSpecificRandomNumber % (_vaultTwabTotalSupply);
+    uint256 constrainedRandomNumber = UniformRandomNumber.uniform(_userSpecificRandomNumber, _vaultTwabTotalSupply);
     uint256 winningZone = calculateWinningZone(_userTwab, _vaultContributionFraction, _tierOdds);
 
     return constrainedRandomNumber < winningZone;