Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed shutdown withdrawals #111

Merged
merged 11 commits into from
Apr 17, 2024
Merged

Fixed shutdown withdrawals #111

merged 11 commits into from
Apr 17, 2024

Conversation

asselstine
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Apr 16, 2024

GEN-1337 investigate shutdownBalanceOf logic

@github-actions GitHub Actions
Copy link

LCOV of commit 8816a1d during Tests with 100% Coverage #517

Summary coverage rate:
  lines......: 100.0% (431 of 431 lines)
  functions..: 97.3% (71 of 73 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    195|95.0%    40|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     61| 100%     5|    -      0

@github-actions GitHub Actions
Copy link

LCOV of commit ca9aa77 during Tests with 100% Coverage #519

Summary coverage rate:
  lines......: 100.0% (431 of 431 lines)
  functions..: 97.3% (71 of 73 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    195|95.0%    40|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     61| 100%     5|    -      0

@github-actions GitHub Actions
Copy link

LCOV of commit debf5af during Tests with 100% Coverage #521

Summary coverage rate:
  lines......: 100.0% (431 of 431 lines)
  functions..: 97.3% (71 of 73 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    195|95.0%    40|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     61| 100%     5|    -      0

@github-actions GitHub Actions
Copy link

LCOV of commit f651ab2 during Tests with 100% Coverage #523

Summary coverage rate:
  lines......: 100.0% (431 of 431 lines)
  functions..: 97.3% (71 of 73 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    195|95.0%    40|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     61| 100%     5|    -      0

@github-actions GitHub Actions
Copy link

LCOV of commit 8af819c during Tests with 100% Coverage #525

Summary coverage rate:
  lines......: 100.0% (513 of 513 lines)
  functions..: 97.4% (76 of 78 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    225|95.5%    44|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     61| 100%     5|    -      0

@asselstine asselstine force-pushed the gen-1337-investigate-shutdownbalanceof-logic branch from dcf76c6 to 9e35c45 Compare April 17, 2024 03:01
@github-actions GitHub Actions
Copy link

LCOV of commit 9e35c45 during Tests with 100% Coverage #529

Summary coverage rate:
  lines......: 100.0% (513 of 513 lines)
  functions..: 97.4% (76 of 78 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    225|95.5%    44|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     61| 100%     5|    -      0

trmid
trmid requested changes Apr 17, 2024
View reviewed changes
src/PrizePool.sol Show resolved Hide resolved
@trmid trmid mentioned this pull request Apr 17, 2024
Merged
@github-actions GitHub Actions
Copy link

LCOV of commit f26119f during Tests with 100% Coverage #537

Summary coverage rate:
  lines......: 99.8% (519 of 520 lines)
  functions..: 97.5% (78 of 80 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          |99.6%    232|95.7%    46|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     61| 100%     5|    -      0

⛔ The code coverage is too low. Expected at least 100.

@github-actions GitHub Actions
Copy link

LCOV of commit 6f827b2 during Tests with 100% Coverage #539

Summary coverage rate:
  lines......: 99.8% (519 of 520 lines)
  functions..: 97.5% (78 of 80 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          |99.6%    232|95.7%    46|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     61| 100%     5|    -      0

@asselstine asselstine merged commit b3b672e into main Apr 17, 2024
2 checks passed
@asselstine asselstine deleted the gen-1337-investigate-shutdownbalanceof-logic branch April 17, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trmid trmid trmid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asselstine @trmid