Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce minimum draw timeout and clarify natspec #117

Conversation

trmid
Copy link
Member

@trmid trmid commented Jun 27, 2024

The prize pool needs at least 2 draw periods since the last awarded draw to ensure there is enough time for the draw manager to award a draw; therefore the draw timeout must be at least 2 otherwise the prize pool will never award a draw and will shutdown immediately after the first draw period closes.

Also clarified the drawTimeout natspec to explicitly state that the value is equal to the number of draws that have passed since the last awarded draw.

@trmid trmid requested a review from asselstine June 27, 2024 16:18
Copy link

linear bot commented Jun 27, 2024

Copy link

LCOV of commit ba4b59d during Tests with 100% Coverage #562

Summary coverage rate:
  lines......: 99.8% (519 of 520 lines)
  functions..: 100.0% (80 of 80 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          |99.6%    232| 100%    46|    -      0

src/PrizePool.sol Outdated Show resolved Hide resolved
Copy link

LCOV of commit ddf87b3 during Tests with 100% Coverage #567

Summary coverage rate:
  lines......: 99.8% (530 of 531 lines)
  functions..: 100.0% (83 of 83 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          |99.6%    232| 100%    46|    -      0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants