Add reserve increasing #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Trevor Richard <40277611+trmid@users.noreply.github.com>
asselstine
requested changes
Jul 6, 2023
src/PrizePool.sol
Outdated
| /// @param user The user attempting to increase the reserve | ||
| /// @param balance The user's current balance | ||
| /// @param amount The amount that the reserve is being increased by | ||
| error InsufficientPrizeTokenBalance(address user, uint256 balance, uint256 amount); |
There was a problem hiding this comment.
Where did this come from?
src/PrizePool.sol
Outdated
| @@ -167,6 +173,10 @@ contract PrizePool is TieredLiquidityDistributor { | |||
| /// @param amount The amount of assets transferred | |||
| event WithdrawReserve(address indexed to, uint256 amount); | |||
|
|
|||
| /// @notice Emitted when the reserve is manually increased. | |||
| /// @param amount The amount of assets transferred | |||
| event IncreaseReserve(uint256 amount); | |||
There was a problem hiding this comment.
Should prob include the user that increased?
asselstine
approved these changes
Jul 6, 2023
asselstine
deleted the
dylan/gen-63-allow-someone-to-deposit-directly-into-the-prizepool-reserve
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.