Merge pull request #11 from GenerationSoftware/gen-353-macro-issue-q-…

…13-events-emitted-in-twabcontroller-even-when Only emit events when amounts non-zero
GenerationSoftware · Aug 16, 2023 · f55d8b2 · f55d8b2
2 parents 8381358 + 2b58494
commit f55d8b2
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/TwabController.sol b/src/TwabController.sol
@@ -667,7 +667,9 @@ contract TwabController {
     ) = TwabLib.increaseBalances(PERIOD_LENGTH, PERIOD_OFFSET, _account, _amount, _delegateAmount);
 
     // Always emit the balance change event
-    emit IncreasedBalance(_vault, _user, _amount, _delegateAmount);
+    if (_amount != 0 || _delegateAmount != 0) {
+      emit IncreasedBalance(_vault, _user, _amount, _delegateAmount);
+    }
 
     // Conditionally emit the observation recorded event
     if (_isObservationRecorded) {
@@ -710,7 +712,9 @@ contract TwabController {
       );
 
     // Always emit the balance change event
-    emit DecreasedBalance(_vault, _user, _amount, _delegateAmount);
+    if (_amount != 0 || _delegateAmount != 0) {
+      emit DecreasedBalance(_vault, _user, _amount, _delegateAmount);
+    }
 
     // Conditionally emit the observation recorded event
     if (_isObservationRecorded) {
@@ -752,7 +756,9 @@ contract TwabController {
       );
 
     // Always emit the balance change event
-    emit DecreasedTotalSupply(_vault, _amount, _delegateAmount);
+    if (_amount != 0 || _delegateAmount != 0) {
+      emit DecreasedTotalSupply(_vault, _amount, _delegateAmount);
+    }
 
     // Conditionally emit the observation recorded event
     if (_isObservationRecorded) {
@@ -786,7 +792,9 @@ contract TwabController {
     ) = TwabLib.increaseBalances(PERIOD_LENGTH, PERIOD_OFFSET, _account, _amount, _delegateAmount);
 
     // Always emit the balance change event
-    emit IncreasedTotalSupply(_vault, _amount, _delegateAmount);
+    if (_amount != 0 || _delegateAmount != 0) {
+      emit IncreasedTotalSupply(_vault, _amount, _delegateAmount);
+    }
 
     // Conditionally emit the observation recorded event
     if (_isObservationRecorded) {