-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dcw-collection.txt #31
Conversation
List of sub-regions of countries from UN49. https://en.wikipedia.org/wiki/UN_M49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Please make two changes:
- Add the URL to the wikipedia description of the geoscheme in the header section.
- Add list: in from of all the lists of codes.
Ok. About 2) you mean I should modified each list like this, right? list: DZ,EG,LY,MA,SD,TN,EH |
Hmm, not related to this but the -RAF area extends too much to South (Kergelen should not be included) a to the East where it should stop a bit east of Madgascar. |
I agree. For this, we should remove AF of some countries/territories from dcw-countries.txt. In the other continents there are similar cases. |
Maybe similar to what we had to do to Norway - strip off that Spitsbergen outlier. |
I think that the main issue is that we are defining the continent (=AF, =AS, =EU, etc) as a collection of countries and not geographically. And sometimes this include small islands far away from the shore or exclave (like Kaliningrad). Which is similar of what we are doing with UN M49. |
No longer case-sensitive. Also, fixed issue so that parsing error in these files leads to an error and exit. |
Two questions:
|
I fixed the Arctic Ocean which had a strange w/e (not quite 360) and north exceeded 90.
the difference between 20.000000000000057 and 20 are a few nanometers... Surely none of these borders are more accurate than a meter, meaning we should probably truncated to 6 decimals? 1e-6 * 111113 m = 11 cm. |
Yes, I took them from the shp file. It is NOT the official tag (of IHO53) but I think we can use them to avoid case-sensitive issues. |
Do you mean to add the continents in the list? Yes, it is possible. They have an official number like the sub-regions. It would something like:
It would be possible to call the other sub-regions? like:
I am not sure if understand correctly. Do you other regions define by another organism? Or by the UN? |
From the paper of Fourcy and Lorvelec: "Positioning precision of reference points is approximately 10 s of meridian arc (about 300 m)." |
Sorry, I meant can we find official w/e/s/n regions for all continents and then we use that for AF etc instead of a list of countries, since that includes Kerguelen and other troubles. |
OK, so on resolution I think reformat to %.6lg to avoid those long we/s/n/ strings |
Do you mean to have the limits of the continents based of the geology (so excluding all the island that are included in a continent). And the problem would be for example how to differentiate the geological Africa from the geopolitical Africa, right? I think I could get the w/e/s/n for the geological continents (which can't be based on countries due to the issue with islands and intercontinental countries like Russia). |
Add the tags and lists for Africa, Sub-saharan Africa, Americas, Latin American and the Caribbean, Antarctica, Asia, Europe and Oceania.
Here you idea is to remove the continents of the DCW? Because I am seeing the continents defined by the UN is different from the DCW. For example Russia is in Europe, Greenland in America. So |
I think we should follow the UN - that should be more reputable than whatever DCW did. I cannot recall exactly how I did things initially but I am the one who assigned countries to continents (I think) so that could be wrong. |
Ok. So I should reorganize the countries in the dcw folders, right? |
Yes, if you have time. I need to do some errands this morning so will be back in a few hours. |
About the list and regions of dcw-collection in general. I think that it would be good to have like smaller collections (like Balcans, Scandinavian or Greater and Less Antilles) but I didn't find any official list (like UN). So maybe we can leave that additions for a second version of this list. What do you think? |
Yes, I have just to fix those issues. For Micro/Mela/Polynesia I also have to compare with the UN definition. |
I think the bounding boxes are a bit too tight. See Africa, Europe (trims a bit of Ireland), Iberia (shaves the westernmost points). Maybe add a little pad to all of them? But that pad must probably proportional to width/height. |
Yes, I meant this when I said "adjust some values".
Do you mean an extra space between the shore and the bounding box? |
I checked the shp. Europe = Continental Europa so that is why Ireland is trim. It is part of British Isles. Should we include them in Europe, right?
Which are they? The Berlengas Islands? |
Abasolutely.
It's the westernmost tip of continental Europe. "Cabo da Roca". But the "Andes" is even worst. And we used to have Europe extending till the Azores. |
Thanks Joaquim. I will keep in mind. Another issue. I will add the info of major lakes. I can use directly the GSHHG level 2. I noticed that the bounding box is included in the header so would be easy. Maybe in the future we could add the tag directly on it? What do you think?
|
I thin maybe it is OK to add a name at the end of those records but would need to check to code in src that it does not break anything. |
I have a doubt. What GSHHG resolution should I use to extract the bounding box? I was thinking |
I add the 14 major lakes (by area) plus the Great Lakes from wikipedia. Also add the biggest islands (greater than 25,000 km2) also from [wikipedia]. (https://en.wikipedia.org/wiki/List_of_islands_by_area). I do not include islands that can be drawn trough DCW (Iceland, Cuba, Madagascar, Hispaniola, Tasmania, etc). I also want to add some main archipelagos (Canary, Madeira, Galapagos, etc). I here suggestions to add. I get the shoreline from the full version of GSHHG level 2 (and 6 for two antarctic islands) so it shouldn't be any problem with the bounding box (but please check). |
I think we could even call the entire island from here. To be clear, if I want to get the coastline of Siciliy, I could write something like `gmt coast -LetterSicily -M -W > Sicily.txt" and GMT would extract only the coastline of the the polygon called Sicily. So we would have to add a name (and a code) in the headers, and @PaulWessel would have to write some code to search for the name (or code). |
All the resolutions file has the same bounding box (full) for each feature. However, lower resolution will have fewer features. I think the large things you are considering should be in all, with the possible exception of crude. |
Ok. I also use full resolution because that was used to define the limits of the sea regions. |
I fix the geographic regions and make topographic grid from the gebco grid. What do you think? For some regions, maybe the values can be adjust a bit more but I think that it is too much work for a very little detail. So I am thinking of leave these regions as they are. Although if you want to fix some particular region, I could do it (let me know). Remember that this is just a sub-set of the regions. Others are lists of countries (from UN and others), regions of seas/oceans, major lakes, biggest islands and some main archipelagos. |
I have this Julia function that should be pretty useful for this. A made up example
|
Thanks. Looks fine but the main issue is that the geographic regions of the shp are based in another coastline (not GSHHG) and the error it can be 0.0x degress. So I would need to revise them manually (which is too much). |
I upload the collections to revise in 3 files. The first 2 are based on bounding box regions, the 3rd is a list of countries. In all of them I include the long name (title) and code (label). For the codes I used mostly 4 letters.
In total there are 244 regions. Maybe we could go up to 250? |
Updated with all the llists and regions used in the pdfs.
Very nice work, @Esteban82! I think 244 is quite a few already and we can always add more later. |
Ok, thanks @PaulWessel. So please revised so we can merge it. PS: I remove the "WIP" from the title. |
I just wonder if these pdf should be available for the user to sea more easily the lists and regions. |
I am not sure where they could go. However, maybe those batch scripts could be added as examples for how users can visualize all things. Or maybe @meghanrjones has a better idea. |
I like the idea of sharing example scripts along with the figures. Are the batch scripts posted anywhere? |
I will share them soon. |
I share a zip file which has 3 files and its respective lists. |
List of sub-regions of countries from UN49.
https://en.wikipedia.org/wiki/UN_M49