Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the anatomy of a figure tutorial #7

Merged
merged 6 commits into from May 15, 2022
Merged

Add the anatomy of a figure tutorial #7

merged 6 commits into from May 15, 2022

Conversation

leouieda
Copy link
Member

Create the notebook and add it to the TOC. Start with creating a figure
and adding coast line elements to it.

Create the notebook and add it to the TOC. Start with creating a figure
and adding coast line elements to it.
@weiji14
Copy link
Member

weiji14 commented May 10, 2022

To add a title with multiple words, you must use single quotes '' on the outer string and double quotes "" around the title

FYI, as of PyGMT v0.6.0 (GenericMappingTools/pygmt#1487), spaces are allowed in the titles, i.e. "+tCoastlines around Japan" would work. So you can remove this important note 😉

@leouieda
Copy link
Member Author

I noticed while doing this actually! But the docs said that they were mandatory so I thought it might just be something about my setup. Good to know!

Apparently not needed anymore since PyGMT 6.3
Use the Japan quakes data but don't set the size as we do in the docs
since that's adding too much complexity. Add a colorbar with a frame but
only the default position.
@leouieda leouieda marked this pull request as ready for review May 10, 2022 15:57
@leouieda
Copy link
Member Author

Hi all, this is ready for a review. The content is probably a bit too much for 20 minutes but I think it will fit. I'll do a trial recording now to see how it goes. Any feedback would be appreciated. I can make a final recording later after feedback.

@weiji14
Copy link
Member

weiji14 commented May 11, 2022

Looks pretty good! Just a couple of suggestions:

  1. Bring some of the headings up a level. I.e. make h2->h1 and h3->h2. E.g. instead of ### Adding minor ticks, do ## Adding minor ticks so that they show up on the right sidebar. Or if you know of a jupyter-book setting to show h3 headings, I'm all ears!
  2. I kinda feel like you could decrease the region's xmin a bit, maybe something like region = [125, 155, 30, 55] to make Japan a bit more centred in the middle of the map?

@leouieda leouieda changed the title Start the anatomy tutorial Add the anatomy of a figure tutorial May 13, 2022
@leouieda
Copy link
Member Author

Alright, made the changes suggested by @weiji14 (thanks!) and made a recording: https://www.dropbox.com/s/fsalumnpgzz4ix6/egu22-pygmt-first-figure.mp4?dl=0

It's at a little over 21 min. I can try to do some cuts to get it down to 20 min if needed. Any feedback would be great!

@weiji14
Copy link
Member

weiji14 commented May 13, 2022

Alright, made the changes suggested by @weiji14 (thanks!) and made a recording: https://www.dropbox.com/s/fsalumnpgzz4ix6/egu22-pygmt-first-figure.mp4?dl=0

It's at a little over 21 min. I can try to do some cuts to get it down to 20 min if needed. Any feedback would be great!

The recording looks great, honestly couldn't find anything major to nitpick on, and I think you've explained the basic PyGMT/GMT concepts really well 😄 21min should be ok for now, let's see how long the other presentations are and we can trim it to <= 20min if needed.

@weiji14
Copy link
Member

weiji14 commented May 13, 2022

If you clear the notebook cells and push another commit, I can approve and get this merged into the main branch.

@joa-quim
Copy link
Member

Hi Leo. Congrats, very nice tutorial indeed. I was surprised though with one part of it. When you painted the land in lightgreen with the single command fig.coast(land="lightgreen") the figure came out with both painted land and ocean. How is that possible?

@leouieda
Copy link
Member Author

@weiji14 done 👍🏾

@joa-quim thanks! The figure is built dynamically so that call is adding to a pre-existing figure that already had the water. No magic there 🙂

@weiji14 weiji14 merged commit 023cd59 into main May 15, 2022
@weiji14 weiji14 deleted the figure-anatomy branch May 15, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants