Avoid compiler warnings related to not heeding errors #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d dangerous use of strncat.
joa-quim
reviewed
Oct 18, 2018
There was a problem hiding this comment.
I tried the dummy trick before but than I will get a new warning about a variable not being used. So basically that only changes the warning message.
And please, do not change the indentations that I careful have been doing. Above all, do not change spaces by tabs in those indentations. A criterious mix of tabs and spaces (tabs first till aligning with above line, followed by spaces) is needed so that different tab size (2 vs 4 vs 8) by different editors (or the same) always show up the correct indentation.
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
Add a sphinx extension `gmt.sphinxext.gmtplot` to the package. It enables the `gmt-plot` directive that executes the given code, captures the output of `gmt.Figure.show` and stdout, and inserts them into the rst document. Includes a plot in the front page and a page documenting the extension. It also serves as a test for the extension. The code is not tested with pytest. This could possibly be done using [sphinx-testing](https://github.com/sphinx-doc/sphinx-testing). Fixes GenericMappingTools#129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kills a number of compiler warnings. In response to issue #128.
(Note: my editor kills empty spaces at end of line, so hence additional chunks of changes).