Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign documentations #1308

Merged
merged 58 commits into from Sep 16, 2019
Merged

Redesign documentations #1308

merged 58 commits into from Sep 16, 2019

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 6, 2019

@leouieda I create the PR so that we can easily track the progress and contribute PRs to the docs-refactor branch.

This PR is related to #805, #816, #851, #870, #871.

Vendor in the theme source so we don't have to install it in order to
build it.
Create module list pages for the modern and classic modules.
Still need to include all modules from the supplements in the classic
reference.
Remove the duplicate "Module Purpose" page but keep its content in the
main module reference. Still need to move the supplements into that list as
well.

Rename the gallery and move the main page into gallery/
@leouieda
Copy link
Member

leouieda commented Aug 6, 2019 via email

seisman and others added 4 commits August 19, 2019 09:52
Add the _static folder to hold our favicon and custom CSS.
Move some ugly file names like "GMT_*" to lowercase shorter names.
@leouieda
Copy link
Member

Hi @seisman sorry for the delay. I'm pushing in some changes I made recently. Please don't merge master or 6.0 branches here since it creates a lot of conflicts that need to be resolved. Or at least give me a heads up 😉

@seisman
Copy link
Member Author

seisman commented Aug 28, 2019

@leouieda Sorry for making the conflicts. I've rebased the PR #1330 on top of this branch. I think at least some of the commits in #1330 can be cherry-picked into this PR.

@seisman
Copy link
Member Author

seisman commented Sep 8, 2019

It seems @leouieda is busy and have limited time working on the documentations. Maybe I can take over this branch and commit changes directly, so that we can have the new documentation ready when releasing 6.0.0.

@PaulWessel
Copy link
Member

I know, but I think we need to give @leouieda a chance to resurface on Monday at the latest. If nothing by Monday night GMT then you can make changes.

@seisman
Copy link
Member Author

seisman commented Sep 8, 2019

👌

@leouieda
Copy link
Member

leouieda commented Sep 10, 2019

Hi guys, sorry for the disappearance. It's ok with me if @seisman takes over this PR. A few things that were left unfinished:

  • Break the tutorial document into several documents. I'm thinking one for each chapter and include them separately in the index.rst toc table.
  • Add some text to the front page about GMT, how the docs are laid out and where to start if you don't know anything about GMT.
  • A page explaining modern mode (Modern mode primer) for people who know GMT. Could be taken directly from the paper.

@seisman
Copy link
Member Author

seisman commented Sep 15, 2019

Although the new documentations still needs more improvements, I think it's OK to replace the old documentations. As we have many files renamed or removed in the new documentations, modifying the old documentations may lead to a lot of conflicts which need to be solved. So I think we can merge it into 6.0 branch ASAP, so that we can improve the documentations efficiently.

You can preview the new documentations by visit this temporary site.

@seisman seisman requested a review from a team September 15, 2019 04:13
@leouieda
Copy link
Member

@seisman great job on this! It looks really good. I agree that this can be merged and worked on in later PRs. The only question I have is about the classic mode tutorial and cookbook links. It's a bit strange to me that they go to the GMT 5 docs. I'd rather not have those toctree items and put a note on the tutorial and cookbook pages points to GMT 5 with some explanation why. Like we did in the Core Modules page. Something like:

Looking for the classic mode tutorial? Since classic mode commands haven't changed since GMT 5, please visit the GMT 5 tutorial page instead.

@joa-quim
Copy link
Member

Sorry, I've not paid much attention to this. I looks very nice.
I note however that we lost the GMT -J codes.

Also, history is round. we came back to GMT3-4 were modules were resented in thematic categories. I'm sorry to disagree here but I always searched in the alphabetic order.

We should have a GMT Core Modules - thematic and a Core Modules - alphabetic entries that users can change as bookmarks depending on their preferences.

@PaulWessel
Copy link
Member

Hi @seisman and @leouieda - this looks very nice; thank you! I think this looks good enough to publish for GMT 6.0.0. I do agree with @joa-quim that having alphabetical access is what you want when you know which module you need to look up instead of hunting for it a bit under the categories, but we can add that as he suggests if we find it really is a problem. The -J codes page: Seems like that could easily be added under the Reference Documentation heading. Maybe call it "Projection Specifications" and add it just after common options?

@seisman
Copy link
Member Author

seisman commented Sep 16, 2019

I've addressed some of the comments above, and the new documentation is available from https://seisman.github.io/gmt-docs-preview/.

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Possible improvements would be somehow to align the tables in the supplemental model listing since each supplement has different table size - looks odd.

@seisman
Copy link
Member Author

seisman commented Sep 16, 2019

The core module list (https://seisman.github.io/gmt-docs-preview/modules.html) has the same problem, because we're using multiple tables for thematic categories. Will see how to fix it later.

@seisman seisman merged commit 146e5b9 into 6.0 Sep 16, 2019
@seisman seisman deleted the docs-refactor branch September 16, 2019 04:04
@KristofKoch
Copy link
Contributor

May I show you a problem I just noticed with the theme @seisman chose:

Screenshot

When using the search function the term searched for becomes highlighted and the word containing the search term becomes separated into two words. This surely will lead to errors when user don't use copy&paste but read the docs and type their own code. pssolarps solar

@joa-quim
Copy link
Member

Hmm, is it a Mac'ish thing? It doesn't happen to me on Win with both Firefox and Epic. But I'm looking at Dongdong's link page where, BTW, there is no pssolar reference.

@seisman
Copy link
Member Author

seisman commented Sep 16, 2019

The new site is online https://docs.generic-mapping-tools.org/latest/ now. @joa-quim

@seisman
Copy link
Member Author

seisman commented Sep 16, 2019

I can reproduce it with Chrome and Safari, and just found a solution. If you think it's a problem, then I can fix it in minutes.

@PaulWessel
Copy link
Member

PaulWessel commented Sep 16, 2019

Looks like pssolar is missing from classicand modern module list?

@seisman
Copy link
Member Author

seisman commented Sep 16, 2019

I'll add it later.

BTW, I just opened the issue #1567. Please post any problems and suggestions to that issue instead.

obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
Add PyGMT team page listing distinguished contributors with indicators for founders
and active maintainers in a new development toctree. Move contributors and
maintainers guides to the development toctree.

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants