-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for anim12 written in Batch script #4811
base: master
Are you sure you want to change the base?
Conversation
for Windows execute with command prompt tested with gmt 6.1.1
💖 Thanks for opening this pull request! 💖 Please make sure you read our Contributing Guide and abide by our Code of Conduct. A few things to keep in mind:
|
REM | ||
REM The finished movie is available in our YouTube channel as well: | ||
REM https://youtu.be/X8TojLs0NYk | ||
REM The movie took ~4 minutes to render on a 24-core MacPro 2013. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick comments:
- Remove this sentence or show the minutes on your Windows machine.
- Add "author/contributor" or similar information to give the contributors (you) more credit?
- We won't show the batch script in the online documentation, but perhaps we could add a note saying that a batch version is available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Well, maybe someone with good PC specs with windows can test it? im using old pc 7-core windows 10 and takes ~15minutes to do this job :(
- im fine with it :)
- agreed, since most user in my place using windows so better if has example using batch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joa-quim I guess we don't want to maintain batch scripts for our animation examples, right? |
Agree that we don't want to maintain (worst, create versions of) animations batch scripts but I think it would be good to have at least one example to show that Windows users can also write their animations with plain |
https://docs.generic-mapping-tools.org/dev/movie.html ![]() Is this one enough? |
Well, yes but it wouldn't harm either if we had one of the animations as a batch file. And specially in this case that the user already made it. |
I guess we need a Windows user to run the batch scripts to make sure they're correct. |
Actually, the batch version is more difficult to read and understand, because it uses |
for Windows
execute with command prompt
tested with gmt 6.1.1