Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for anim12 written in Batch script #4811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Squadzone
Copy link

for Windows
execute with command prompt
tested with gmt 6.1.1

for Windows execute with command prompt
tested with gmt 6.1.1
@welcome
Copy link

welcome bot commented Feb 15, 2021

💖 Thanks for opening this pull request! 💖

Please make sure you read our Contributing Guide and abide by our Code of Conduct.

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the comments below for your functions describing the it, all arguments, and return types before writing the code. This will help you think about your code design and results in better code.
  • We are grateful that you put in the effort to do this! 🎉

REM
REM The finished movie is available in our YouTube channel as well:
REM https://youtu.be/X8TojLs0NYk
REM The movie took ~4 minutes to render on a 24-core MacPro 2013.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comments:

  1. Remove this sentence or show the minutes on your Windows machine.
  2. Add "author/contributor" or similar information to give the contributors (you) more credit?
  3. We won't show the batch script in the online documentation, but perhaps we could add a note saying that a batch version is available?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Well, maybe someone with good PC specs with windows can test it? im using old pc 7-core windows 10 and takes ~15minutes to do this job :(
  2. im fine with it :)
  3. agreed, since most user in my place using windows so better if has example using batch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seisman
Copy link
Member

seisman commented Jun 6, 2024

@joa-quim I guess we don't want to maintain batch scripts for our animation examples, right?

@joa-quim
Copy link
Member

joa-quim commented Jun 6, 2024

Agree that we don't want to maintain (worst, create versions of) animations batch scripts but I think it would be good to have at least one example to show that Windows users can also write their animations with plain .bat files.

@seisman
Copy link
Member

seisman commented Jun 7, 2024

I think it would be good to have at least one example to show that Windows users can also write their animations with plain .bat files.

https://docs.generic-mapping-tools.org/dev/movie.html

image

Is this one enough?

@joa-quim
Copy link
Member

joa-quim commented Jun 7, 2024

Well, yes but it wouldn't harm either if we had one of the animations as a batch file. And specially in this case that the user already made it.

@seisman
Copy link
Member

seisman commented Jun 13, 2024

I guess we need a Windows user to run the batch scripts to make sure they're correct.

@seisman
Copy link
Member

seisman commented Jun 13, 2024

Actually, the batch version is more difficult to read and understand, because it uses echo extensively to write GMT commands into the pre, main and post scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants