-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update -g synopsis, syntax, usage and docs #5617
Conversation
The -g was a bit awkward (had separate -qa to change a bool value, now we use a modifier like elsewhere. Also, set alternative z-column via +ccol like elsewhere. Fixed wording and minor mistakes in the RST.
I find the new syntax more confusing than before (in particular the relation between z directive and +c modifier). I think this would be more similar to the syntax in other common options: |
Let's discuss this. I see +ccol is used in several places: Common options:
gmtinfo: gmtselect: In that context, this looks similar to me:
Adding the slash if a zcol is specified means more complications in doing a long-option I think. PS. I need to read a thesis and attend a defense and then a Dr visit so will be very intermittent here today. |
OK, I will instead just make a couple small wording suggestions for the new syntax. |
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after the two suggestions removing the extra | in the synopsis are resolved.
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
The -g syntax was a bit awkward (had a separate -qa to change a bool value). Now we use a modifier (+a) like elsewhere. Also, we now set an alternative z-coordinate column via +ccol like elsewhere [2]. Also fixed wording and minor mistakes in the RST and synopsis.