Add grd2xyz option -L to limit output to a single vector #5705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This need comes up all the time and over the years we have done piping via awk, grdtrack -W and probalby other acrobatics. Now, -Lc|r|x|yvalue handles it directly.
PaulWessel
added
the
new core module feature
|
Nice! Just needs to be added to the usage message. |
|
Should now be good to go, @meghanrjones |
maxrjones
reviewed
Aug 26, 2021
Comment on lines
+18
to
+23
| 0 30 0 | ||
| 10 30 300 | ||
| 20 30 600 | ||
| 30 30 900 | ||
| 40 30 1200 | ||
| 50 30 1500 |
There was a problem hiding this comment.
I do not understand why the y coordinates for row index 2 are 30. I would expect them to be 20 based on the grid:
data:
x = 0, 10, 20, 30, 40, 50 ;
y = 0, 10, 20, 30, 40, 50 ;
z =
0, 0, 0, 0, 0, 0,
0, 100, 200, 300, 400, 500,
0, 200, 400, 600, 800, 1000,
0, 300, 600, 900, 1200, 1500,
0, 400, 800, 1200, 1600, 2000,
0, 500, 1000, 1500, 2000, 2500 ;
}
There was a problem hiding this comment.
y-coordinates to up (right-handed coordinate system).
rows start at ymax and go down...
There was a problem hiding this comment.
OK, this should be documented in the option as it is not a universal indexing system (e.g., MATLAB, xarray behavior is opposite).
There was a problem hiding this comment.
Yes, you are right about that. I think this is one of the few places where the user gets to enter a row index. I will add a note to the docs.
maxrjones
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This need comes up all the time and over the years we have done piping via awk, grdtrack -E , project -G and probably other acrobatics. Now, -Lc|r|x|yvalue handles it directly. If given row or column is outside grid limits then a warning ensues and no output is returned. For row and column coordinates we find the nearest row or column so you dont have to worry about getting enough decimals in -Lx0.33333, for instance.
I added a basic test with verified result.