Simplify conversions between km and degrees #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who have data columns representing distances on the Earth (or other planets) will need to convert arc and distance units (mostly degrees and km). This is an awkward thing to do via proxies like +s111.195. In grdmath we have operators DEG2KM for this. For tables I have now implemented special arguments d and k to -i+s. So, -i0+sk will convert spherical degrees in column one to km, using the prevailing mean ellipse radius.
maxrjones
reviewed
Sep 29, 2021
| @@ -16,7 +16,8 @@ one of the following modifiers to any column or column range to transform the in | |||
|
|
|||
| - **+l** to take the **log10** of the input values. | |||
| - **+d** to divide the input values by the factor *divisor* [default is 1]. | |||
| - **+s** to multiply the input values by the factor *scale* [default is 1]. | |||
| - **+s** to multiply the input values by the factor *scale* [default is 1]. Alternatively, give **d** to convert | |||
| km to degrees or **k** to convert degrees to km. | |||
There was a problem hiding this comment.
Suggested change
| km to degrees or **k** to convert degrees to km. | |
| km to degrees or **k** to convert degrees to km using :term:`PROJ_MEAN_RADIUS`. |
|
Yikes, I forgot to accept @meghanrjones suggestion... OK, I added the missing text directly to master... |
maxrjones
added
add-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users (like myself...) who have data columns representing distances on the Earth (or other planets) may need to convert between arc and distance units (mostly degrees and km). This is an awkward thing to do via proxies like +s111.195. In grdmath we have operators DEG2KM and KM2DEG for this. For tables I have now implemented special arguments d and k to -icol+s. So,
-i0+skwill convert spherical degrees in column one to km, using the prevailing mean ellipse radius.No effect on any existing tests, and I checked that both codes work correctly.