Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let grdimage share -T with grdview #7315

Merged
merged 4 commits into from Mar 9, 2023
Merged

Let grdimage share -T with grdview #7315

merged 4 commits into from Mar 9, 2023

Conversation

PaulWessel
Copy link
Member

This PR is creating a function of out grdview -T so it can be called from grdimage as well as grdview. We can consider extending this to handing images (which grdimage may be fed) but for now it is like grdview -T.

Tested on @anbj script and seems to work fine - no test issues. However, need @joa-quim to try this from Julia and passing memory since it is at least possible that something different needs to be done when I call goto basemap_and_free he end.

Creating a function of out grdview -T so it can be called from grdimage as well.
@PaulWessel PaulWessel added the new feature PR that implements a new feature or capability in GMT label Mar 9, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Mar 9, 2023
@PaulWessel PaulWessel requested review from joa-quim and anbj March 9, 2023 12:08
@PaulWessel PaulWessel self-assigned this Mar 9, 2023
Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems from the Julia side.

@PaulWessel PaulWessel merged commit 6b90661 into master Mar 9, 2023
@PaulWessel PaulWessel deleted the T-for-grdimage branch March 9, 2023 13:50
@anbj
Copy link
Contributor

anbj commented Mar 10, 2023

Fantastic - thank you Paul!

Just a PS: Skip nodes with NaN/NaN values transparent: -Q has no effect if -T is used, and basically replaced with T+s. Worth noting in the docs?

@anbj
Copy link
Contributor

anbj commented Mar 10, 2023

One more note: -T+oblack+s -t50 makes the cells transparent, as expected. -T+oblack@50+s -t50 makes nothing transparent ('cancels' the -t50). I don't know if -T+oblack should even accept a @50. Just testing!

@PaulWessel
Copy link
Member Author

You could see if #7322 makes things more stable?

@anbj
Copy link
Contributor

anbj commented Mar 10, 2023

(Getting messy. Tell me if you want a separate issue for this.)

-T+oblack+s -t40 - works as expected.

These do not;

-T+oblack@20+s -t50:

tell-antall-jordskjelv-i-noder

-T+oblack@20+s:

tell-antall-jordskjelv-i-noder

PaulWessel added a commit that referenced this pull request Mar 12, 2023
PaulWessel added a commit that referenced this pull request Mar 13, 2023
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog new feature PR that implements a new feature or capability in GMT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants