Let movie open and play movie if gmt end show is used #7456
Conversation
If the mainscript ends with gmt end show we will use gmt docs to open and play the movie after it has been assembled.
|
It works but I got a lot of messagges related to vlc on the terminal including bold and red letters (see screen capture below) that might looks scary for some users. Is it possible to avoid that? Screencapture:
|
|
Also, if I asked for a a master frame (
Full script |
Yes, with this:
|
Paths was wrong, resulting in different kinds of behaviour on macos and Linux. Now we hvae separate calls to gmt docs with correct paths.
|
@Esteban82, see if this works now for opening both master frame and the movie. I have fixed the path and now explicitly call gmt docs on the master png. Before, I relied on just the gmt end show in the script taking care of it, but there is the issue of moving the plot up one directory. Let me know about your warnings after this commit. |
@PaulWessel it worked. Both files were open. I wonder if it is a good idea to open both files. I think it might be a bit annoying. I wonder if it would be better to open only the mp4 only. And only open the master frame when a video is not requested. |
|
Might also be annoying to some if we don't open both... |
|
I think this is the better solution and I will implement it. |
|
Try this @Esteban82 - works for me and the +v is a better solution for the video. |
|
Got me thinking that having to add/remove show from a script is not a very clean way to do this. Thus +v is good. But we could also add +v as modifier to -M and then we have full control from the command line with no need to modify scripts. What you think? -M[frame|f|m|l,][+v] ? I can even make it backwards compatible if show is in the script. |
|
Sorry, not sure what I copied. -M is [-M][frame],[format][+rdpu][+v] |
|
Yes, I think it is better to have a modifier in the gmt movie command (to open both files). |
|
OK, +v in -M as well as backwards gmt end show check both works. Give it a try and then we can wrap this up. |
|
I am getting an error I think that you it was in the last commit (Add +v to -M) Full script: |
|
Strange, I do
and it works fine for me. Please double-check. Those are error messages from ffmpeg and not movie. I only get the notice:
and there are no ,png strings anywhere. |
This works for me. |
|
I run this script. The movie command works. The second doesn't. It tries to run the below command. I think that the ,png is wrong. I try without it and I got the movie. ffmpeg -loglevel warning -f image2 -framerate 10 -y -i "/home/federico/Github/Esteban82/Pruebas_Privadas/Branch_movie-play/movie-play1/movie-play1_%01d.png" -vcodec libx264 ,png -pix_fmt yuv420p movie-play1.mp4 Full scriptTerminal output |
|
Ok think I get it; work on that after dinner |
|
OK, I had made a mistake by switching some pointers and that came to bite me in parsing -F. Now should work - I was able to see the same error you had and now it is gone. |
|
Now it works. But I am still getting a lot of scary messagges in the terminal. |
|
OK, can you
|
|
I am suspecting it picks ffplay and it has a nasty extensive verbose setting, so then we will need to fix that. |
|
Ok Paul. I do it. I think that the important message is:
Full message: |
|
Hm, could you post your movie-play.sh again. It says line 18
but there is no dev/null, only /dev/null, so something funny is happening but there is no GMT error? |
This seems to indicate that xdc-open is not fully configured somewhere (there should be a hidden file with file type pointing to a suitable application). I found this link about KDE. |
Sorry, I had an extra command on my script. Nothing related to GMT. Forget about this. |
|
Does that mean you can approve this PR? |
|
Sorry, I couldn't test again. |
Thanks. This fix the warning messages. |
If the mainscript ends with
gmt end showwe will use gmt docs to open and play the movie after it has been assembled. Closes #7455.