Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifier +hheight to set logo height instead of width #7458

Merged
merged 1 commit into from May 12, 2023

Conversation

PaulWessel
Copy link
Member

Since the logo aspect ratio is fixed, one can only specify one of the dimensions. This PR adds +h and makes it clear in the synopsis and usage that both are optional [Default is 144p wide logo].

Since the logo aspect ratio is fixed, one can only specify one of the dimensions.  Tis PR adds +h and makes it clear in th synopsis and usage that both are optional [Default is 144p wide logo].
@PaulWessel PaulWessel added the enhancement Improving an existing feature label May 11, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone May 11, 2023
@PaulWessel PaulWessel requested a review from Esteban82 May 11, 2023 19:49
@PaulWessel PaulWessel self-assigned this May 11, 2023
@PaulWessel PaulWessel added the add-changelog Add PR to the changelog label May 11, 2023
@Esteban82
Copy link
Member

I can't merge it. There are two checks errors.

@seisman seisman merged commit 031b5cf into master May 12, 2023
6 of 8 checks passed
@seisman seisman deleted the logo-height branch May 12, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants