Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wm|M to mapprojects's reportoire #7611

Merged
merged 3 commits into from Jul 5, 2023
Merged

Add -Wm|M to mapprojects's reportoire #7611

merged 3 commits into from Jul 5, 2023

Conversation

PaulWessel
Copy link
Member

See #7541. This experimental branch implements -Wm and -WM with this result:

-Wm:

gmt mapproject -R95/5/108/20+r -Ju46/1:10000000 -F -C -Wm
721387.055456	2080949.09788	552077.474203	2279563.58956

-WM:

gmt mapproject -R95/5/108/20+r -Ju46/1:10000000 -F -C -WM
-R721387.0554559267/2080949.097875784/552077.4742030394/2279563.589555113

This should make it easier to mix basemaps with geographic or Cartesian annotations:

gmt begin utm
	gmt coast -W -Na --MAP_FRAME_AXES=SE -R95/5/108/20+r -Ju46/1:10000000 -B
	Rcart=$(gmt mapproject -F -C -WM)
	gmt basemap --MAP_FRAME_AXES=NW $Rcart -Jx1:10000000 -B
gmt end show

Hoping @jidanni can build and test and hunt for any errors.

See #7541.  This experimental branch impoements -Wm and -WM with this result:

-Wm:

gmt mapproject -R95/5/108/20+r -Ju46/1:10000000 -F -C -Wm
721387.055456	2080949.09788	552077.474203	2279563.58956

-WM:

gmt mapproject -R95/5/108/20+r -Ju46/1:10000000 -F -C -WM
-R721387.0554559267/2080949.097875784/552077.4742030394/2279563.589555113

This should make it easier to mix basemaps with geographic or Cartesian annotations.
@PaulWessel PaulWessel added the enhancement Improving an existing feature label Jul 5, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Jul 5, 2023
@PaulWessel PaulWessel requested a review from joa-quim July 5, 2023 09:30
@PaulWessel PaulWessel self-assigned this Jul 5, 2023
ymax *= fwd_scale;
}
}
w_out[XLO] = xmin; w_out[XHI] = xmax;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some alignment issues here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You bet. Fixed.

@PaulWessel PaulWessel changed the title WIP Add -Wm|M to mapprojects's reportoire Add -Wm|M to mapprojects's reportoire Jul 5, 2023
@PaulWessel PaulWessel merged commit 071c3d4 into master Jul 5, 2023
6 checks passed
@PaulWessel PaulWessel deleted the projmap-region branch July 5, 2023 19:10
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants