Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that sphdistance -Q is given a file #7619

Merged
merged 2 commits into from Jul 7, 2023
Merged

Check that sphdistance -Q is given a file #7619

merged 2 commits into from Jul 7, 2023

Conversation

PaulWessel
Copy link
Member

Somehow forgot to use gmt_get_required_file for the -Q option. Now we get message like

sphdistance [ERROR]: Option -Q: No argument provided

instead of

sphdistance [ERROR]: Cannot find file 
sphdistance [ERROR]: Cannot find file 
sphdistance [ERROR]: File  not found
[Session gmt (0)]: Error returned from GMT API: GMT_FILE_NOT_FOUND (16)

@PaulWessel
Check that sphdistance -Q is given a file
bca801b 
Somehow forgot to use gmt_get_required_file for the -Q option.
@PaulWessel PaulWessel added enhancement Improving an existing feature maintenance Boring but important stuff for the core devs labels Jul 7, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Jul 7, 2023
@PaulWessel PaulWessel requested a review from joa-quim July 7, 2023 13:30
@PaulWessel PaulWessel self-assigned this Jul 7, 2023
@PaulWessel PaulWessel merged commit 5d0f7c6 into master Jul 7, 2023
6 checks passed
@PaulWessel PaulWessel deleted the sph-Q-file branch July 7, 2023 13:40
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joa-quim joa-quim joa-quim approved these changes

Assignees

@PaulWessel PaulWessel

Labels
add-changelog Add PR to the changelog enhancement Improving an existing feature maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PaulWessel @joa-quim @maxrjones