Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the curves in events to do linear, quadratic or cosine ramp #7680

Merged
merged 19 commits into from Aug 14, 2023

Conversation

PaulWessel
Copy link
Member

So far all of the magnification curves have been quadratic. This PR adds optional directives l(inear), q(uadratic) or c(osine ramp) to the rise, decay and fade sections. E.g, cosine ramp rise of 2 time units would use the -E modifier +rc2. Below shows the 4 curves for each type (the dashed curve is the default size curve when no curve tweaks have been requested (i.e., no rise, plateau, etc):

lines

It is a WIP for now since we are playing with this a bit and may add this one as new test eventually.

So far all of the magnification curves have been quadratic.  This PR adds optional directives l(inear), q(uadratic) or c(osine ramp) to the rise, decay and fade sections.  E.g, linear rise of 2 time units would use the -E modifier +rl2.
@PaulWessel PaulWessel added the enhancement Improving an existing feature label Jul 25, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Jul 25, 2023
@PaulWessel PaulWessel self-assigned this Jul 25, 2023
@PaulWessel PaulWessel changed the title WIP Enhance the curves in events to do linear, quadratic or cosine ramp Enhance the curves in events to do linear, quadratic or cosine ramp Aug 14, 2023
@PaulWessel
Copy link
Member Author

Finally got this done so it can be used in 6.5 for the animation paper. @Esteban82 please give this branch a test and let me know if anything breaks.

@Esteban82
Copy link
Member

It is working fine. I run psevents.sh and I got the same figure.

lines

@PaulWessel PaulWessel merged commit 9453d77 into master Aug 14, 2023
6 checks passed
@PaulWessel PaulWessel deleted the event-ramps branch August 14, 2023 13:17
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants