New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the curves in events to do linear, quadratic or cosine ramp #7680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far all of the magnification curves have been quadratic. This PR adds optional directives l(inear), q(uadratic) or c(osine ramp) to the rise, decay and fade sections. E.g, linear rise of 2 time units would use the -E modifier +rl2.
PaulWessel
changed the title
WIP Enhance the curves in events to do linear, quadratic or cosine ramp
Enhance the curves in events to do linear, quadratic or cosine ramp
Aug 14, 2023
Finally got this done so it can be used in 6.5 for the animation paper. @Esteban82 please give this branch a test and let me know if anything breaks. |
Esteban82
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far all of the magnification curves have been quadratic. This PR adds optional directives l(inear), q(uadratic) or c(osine ramp) to the rise, decay and fade sections. E.g, cosine ramp rise of 2 time units would use the -E modifier +rc2. Below shows the 4 curves for each type (the dashed curve is the default size curve when no curve tweaks have been requested (i.e., no rise, plateau, etc):
It is a WIP for now since we are playing with this a bit and may add this one as new test eventually.