Treat stroke symbols like other symbols #7789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to #7788 for background. This WIP PR covers psxy and seems to work as explained. Will do the same for psxyz.
they share the same stroke symbols.
PaulWessel
changed the title
PaulWessel
added
documentation
|
Completed, with MAP_STROKE_WIDTH default to 15%. Note if MAP_STROKE_WIDTH is set to 0 then ancient rules still apply (i.e., -W or default pen).
|
Esteban82
approved these changes
Sep 6, 2023
|
Unless objections the new 30 minutes, I will merge this branch into master. I am then down to 45 failures on macOS, most involving grid images but there are a few that probably are odd roundoff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #7788 for background. This WIP PR covers psxy and seems to work as explained. Will do the same for psxyz. Only unsettled issue is default and/or variable scaling from symbol size to pen width.