New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let psconvert -N+kfill set alternate fade fill #7972
Conversation
Movie allows two fill settings that are passed to psconvert when building the rasters WIth -G one can fill the bounding box with selected color before other things are painted With -K (and -E) one can specify what the terminal fade color should be [black]. Unfortunately, psconvert only had -N+g to accept the backgorund fill and the fade color was passed the same way via -N+g, resulting in two different +g<color> modifier passed to psconvert, which then used the last one given. THis PR adds +kfadefill to -N and updates movie to pass that modifier to psconvert when the fading color is explicitly set.
I see now that the default color for the fade is black while the canvas color is white (no fill). Wouldn't be better to have the same default color? I know that it is not important. |
If they both were white or black, you would fade from white to white or black to black. Since -G changes background from white it makes most sense to me to default fade from black if -K or -E is used. |
Mmm, yes, you will see the content of the last frame dissapear (to white or black). But, I am ok with your solution. |
See #7593 for some background. movie allows two fill settings that are passed to psconvert when building the rasters:
Unfortunately, psconvert only had -N+g to accept the background fill and the fade colour was passed from movie the same way via -N+g, resulting in two different +gcolor modifier passed to psconvert, which then of course used just the last one given. Thus, fade was always black.
This PR does several things:
psconvertoptions
in figureCloses #7593
ffmpeg3.mp4