Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug and allow +apangle for decorated lines #8182

Merged
merged 2 commits into from Dec 11, 2023
Merged

Conversation

PaulWessel
Copy link
Member

@PaulWessel PaulWessel commented Dec 11, 2023

This fixes the bug in #7591. While at it, we allow +apangle to let the symbol angle deviate by angle from the line's angle. And +aangle still sets a fixed angle regardless of angle contortions. Closes #7591.

Original post with +a20 (well, after I tilted the line).

deco_lines_rot_gmt2

New +ap20, same line:

deco_lines_rot_gmt

Simply did not pass the fixed angle when it was set and ended up passing the line angle which was zero.
This fixes the bug in #7591. While at it, we allow +apangle to let the symbol angle deviate by angle from the line's angle.+aangle still sets a fixed angle regardless of angle contortions.
@PaulWessel PaulWessel added bug Something isn't working enhancement Improving an existing feature labels Dec 11, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Dec 11, 2023
@PaulWessel PaulWessel self-assigned this Dec 11, 2023
@PaulWessel PaulWessel merged commit a40741f into master Dec 11, 2023
2 of 6 checks passed
@PaulWessel PaulWessel deleted the decorate-ange branch December 11, 2023 14:40
@yvonnefroehlich
Copy link
Member

Thanks @PaulWessel for fixing this bug. Great that this will be included in GMT 6.5.0 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog bug Something isn't working enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotating the symbols of a decorated line does not work ("+aangle")
4 participants