Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -C[cpt] arg to grdmix #8193

Merged
merged 4 commits into from Dec 15, 2023
Merged

Add -C[cpt] arg to grdmix #8193

merged 4 commits into from Dec 15, 2023

Conversation

PaulWessel
Copy link
Member

@PaulWessel PaulWessel commented Dec 15, 2023

This will let grdmix build an image directly from a grid and a CPT (and optionally handle intensity grid as well). Somehow left out in version 1. Includes a new test script to make sure this works.

This will let you build an image directly from a grid and a CPT (and optionally handle intensity grid as well).
@PaulWessel PaulWessel added documentation Improve documentation enhancement Improving an existing feature labels Dec 15, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Dec 15, 2023
@PaulWessel PaulWessel requested a review from a team December 15, 2023 11:09
@PaulWessel PaulWessel self-assigned this Dec 15, 2023
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
deleted test/baseline/grdmix/grdmix.ps
modified test/baseline/grdmix/

Image diff(s)

Added images

Modified images

Path Old New

Report last updated at commit 28c89e9

@PaulWessel PaulWessel merged commit eadbada into master Dec 15, 2023
7 checks passed
@PaulWessel PaulWessel deleted the grdmix-cpt branch December 15, 2023 11:58
@seisman
Copy link
Member

seisman commented Dec 26, 2023

@PaulWessel It's likely that you forgot to run dvc push when working on this PR.

You need to run dvc push to see if any local changes will be pushed.

@PaulWessel
Copy link
Member Author

Ok, so do this in master since already merged?

@seisman
Copy link
Member

seisman commented Dec 26, 2023

Yes

@PaulWessel
Copy link
Member Author

Done. Got

dvc push
  0% Checking cache in 'https://dagshub.com/GenericMappingTools/gmt.dvc/files/md5'|                                                                                                                                          |0/? [00:00<?,    ?files/s]Exception ignored in: <finalize object at 0x10f801560; dead>
Traceback (most recent call last):
  File "weakref.py", line 591, in __call__
  File "fsspec/implementations/http.py", line 121, in close_session
  File "fsspec/asyn.py", line 80, in sync
NotImplementedError: Calling sync() from within a running loop
Aiohttp retry client was not closed
2 files pushed                     

@maxrjones maxrjones added the add-changelog Add PR to the changelog label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog documentation Improve documentation enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants