-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize scripts #97
Conversation
Hi @seisman. I forgot to say this but given how the entire documentation is built via cmake (and until we make any major changes to how that works), all test, example, and doc scripts must produce just a PS file (not png, etc as these are produced by cmake). For instance, see the test/exmod set of modern mode scripts there. |
So, currently all scripts must generate PS only and set paper size to avoid warnings/errors. Looks like this:
|
Yes, except we don't need to set the PS_MEDIA letter since that is set globally by cmake when these scripts are run. |
3956110
to
174910a
Compare
Thanks for all your work @seisman. However, unless I am missing something it looks like many of the scripts do not start with gmt begin and therefore will run in classic mode. Was this intentional? |
@PaulWessel I'm still working on it. Currently, I only finished scripts related to common options, e.g. GMT_-B_*.sh, GMT_-J.sh, GMT_-R.sh ... For other scripts, I only did the renaming of some modules, e.g. |
66c32db
to
bba599e
Compare
bba599e
to
428eb10
Compare
@PaulWessel I have done following changes in this PR:
Following scripts are not changed, since I'm not sure what to do with these scripts:
You can review the changes now and also update these PS files. |
Some of these scripts (func_F_iso+.sh etc) are called by other scripts. THey are not exposed to any users via documentation - they are jus there to make certain figures in the appendix. We can leave them as is for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we will add these in and see if there are any side-effects.
…ls#97) Instead of having the API for gmt, gmt.clib etc in separate pages, put them all in the same one. sphinx autosummary doesn't support this directly so I'm generating the module references in a dummy page and then including them in api/index.
Description of proposed changes
doc_modern
to modern mode.Fixes Update scripts to modern mode #96