Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap grdvolume #1299

Merged
merged 32 commits into from
Oct 25, 2021
Merged

Wrap grdvolume #1299

merged 32 commits into from
Oct 25, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented May 26, 2021 •
edited
Loading

This pull request wraps the gmt module grdvolume.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label May 26, 2021
@willschlitzer willschlitzer added this to the 0.4.0 milestone May 26, 2021
@willschlitzer willschlitzer self-assigned this May 26, 2021
@willschlitzer willschlitzer changed the title WIP: Wrap grdvolume Wrap grdvolume Jun 15, 2021
@willschlitzer willschlitzer mentioned this pull request Jun 15, 2021
Closed
13 tasks
@weiji14 weiji14 modified the milestones: 0.4.0, 0.5.0 Jun 18, 2021
@willschlitzer willschlitzer marked this pull request as ready for review July 11, 2021 13:50
weiji14
weiji14 reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments for now, you might need to add some more unit tests to increase code coverage for L82 and L96-97.

pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
pygmt/src/grdvolume.py Show resolved Hide resolved
@willschlitzer @weiji14
Apply suggestions from code review
c493776 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
maxrjones
maxrjones reviewed Oct 22, 2021
View reviewed changes
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bunch of formatting fixes for the docs to be rendered properly by Sphinx.

pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
@willschlitzer @maxrjones
Apply suggestions from code review
5150a85 
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
weiji14
weiji14 approved these changes Oct 23, 2021
View reviewed changes
pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Oct 23, 2021
willschlitzer and others added 2 commits October 23, 2021 22:17
@willschlitzer @weiji14
Update pygmt/src/grdvolume.py
dd478e9 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzer
Merge branch 'main' into wrap-grdvolume
52b22c7
seisman
seisman approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except a few comments on docstrings.

pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
pygmt/src/grdvolume.py Outdated Show resolved Hide resolved
@willschlitzer @seisman
Apply suggestions from code review
ece4f8f 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 25, 2021
@seisman seisman merged commit 6f930ac into main Oct 25, 2021
@seisman seisman deleted the wrap-grdvolume branch October 25, 2021 08:48
@willschlitzer willschlitzer mentioned this pull request Mar 14, 2022
Merged
6 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer @maxrjones
@weiji14 @seisman
Wrap grdvolume (GenericMappingTools#1299)
5839263 
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrjones maxrjones maxrjones left review comments

@seisman seisman seisman approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees

@willschlitzer willschlitzer

Labels
feature Brand new feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willschlitzer @seisman @maxrjones @weiji14