Expand table-like input options for pygmt.surface #1455
Conversation
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
|
/format |
There was a problem hiding this comment.
Great work!
Can you please remove this line from /pygmt/src/surface.py in your branch? This function is no longer used in the module, so it does not need to be imported:
Line 12 in 7a94b68
|
Ping @daroari to address the comment #1455 (review) |
|
/format |
|
Hi @daroari, do you think you will have time to finish this pull request? It would be great to get it added to PyGMT 😄 If not, we can either close the PR or I could push the remaining changes needed to this branch, whichever you prefer. |
|
Hi @meghanrjones. Sorry for the delayed response. Would you please push the remaining changes? I was going to do it, but I am not able to do it right now. Sorry for the inconvenience :( |
seisman
added
the
final review call
There was a problem hiding this comment.
Thumbs up from me. Technically, it would be nice to have a unit test to make sure this works (e.g. using pytest.mark.parametrize like for blockm* in #1523), but ok to do it another time too 🙂
maxrjones
added
eswn-workshop
…s#1455) * Expand table-like input options for pygmt.surface * Remove unused imports and variables * Update docstring for data Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Description of proposed changes
This PR expands the table-like input options for pygmt.surface
Closes #1443
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version