Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure.rose: Reorder input parameters to 'data, length, azimuth' #1546

Merged
merged 9 commits into from
Oct 3, 2021
Merged

Figure.rose: Reorder input parameters to 'data, length, azimuth' #1546

merged 9 commits into from
Oct 3, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Address #1479

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 26, 2021
@michaelgrund michaelgrund added this to the 0.5.0 milestone Sep 26, 2021
@michaelgrund michaelgrund mentioned this pull request Sep 26, 2021
Closed
@michaelgrund michaelgrund changed the title Figure.rose(): Reorder parameters length, azimuth, data to data, length, azimuth Figure.rose: Reorder parameters length, azimuth, data to data, length, azimuth Sep 26, 2021
@seisman seisman mentioned this pull request Sep 26, 2021
Merged
5 tasks
@michaelgrund michaelgrund changed the title Figure.rose: Reorder parameters length, azimuth, data to data, length, azimuth Figure.rose: Reorder parameters to 'data, length, azimuth' Sep 27, 2021
@michaelgrund michaelgrund changed the title Figure.rose: Reorder parameters to 'data, length, azimuth' Figure.rose: Reorder input parameters to 'data, length, azimuth' Sep 27, 2021
@seisman seisman mentioned this pull request Oct 2, 2021
Merged
5 tasks
@seisman seisman added deprecation Deprecating a feature maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog and removed skip-changelog Skip adding Pull Request to changelog maintenance Boring but important stuff for the core devs labels Oct 2, 2021
@seisman seisman removed maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 2, 2021
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 2, 2021
@weiji14 weiji14 merged commit b5f825e into main Oct 3, 2021
@weiji14 weiji14 deleted the rose-reorder-paras branch October 3, 2021 02:01
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Oct 3, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@michaelgrund
Figure.rose: Reorder input parameters to 'data, length, azimuth' (Gen…
43be44e 
…ericMappingTools#1546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
deprecation Deprecating a feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelgrund @seisman @weiji14