WIP: Wrap fitcircle #1550
Draft
WIP: Wrap fitcircle #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
May 6, 2022
seisman
reviewed
May 6, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
reviewed
May 10, 2022
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
reviewed
May 24, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 31, 2022
Comment on lines
+119
to
+125
| if outfile == tmpfile.name: # if user did not set outfile, return pd.DataFrame | ||
| result = pd.read_csv( | ||
| tmpfile.name, | ||
| sep="\t", | ||
| names=["longitude", "latitude", "method"], | ||
| comment=">", | ||
| ) |
There was a problem hiding this comment.
$ gmt fitcircle @sat_03.txt -L2
330.249933144 -18.4048179232 Points read: 703 Average Position (Flat Earth)
330.169184777 -18.4206532702 L2 Average Position (Eigenval Method)
52.7451972868 21.2040074195 L2 N Hemisphere Great Circle Pole (Eigenval Method)
232.745197287 -21.2040074195 L2 S Hemisphere Great Circle Pole (Eigenval Method)
$ gmt fitcircle @sat_03.txt -L2 -Fms
330.169184777 -18.4206532702 232.745197287 -21.2040074195
As you can see, the output of fitcircle is quite different with or without -F option, so the read_csv call doesn't work with -F.
I'm wondering should we return a dict instead, e.g.,:
>>> solution = fitcircle(data="@sat_03.txt", norm=2)
>>> print(solution)
{'average': {'latitude': -18.4048179232, 'longitude': 330.249933144},
'L2_average': {'latitude': -18.4206532702, 'longitude': 330.169184777},
'L2_north': {'latitude': 21.2040074195, 'longitude': 52.7451972868},
'L2_south': {'latitude': -21.2040074195, 'longitude': 232.745197287}}
There was a problem hiding this comment.
I can work on this, but I'm about to move so I may not be too speedy
There was a problem hiding this comment.
No hurry. Better to have more discussions about the output before working on it.
|
I don't think I'm able to come up with a good way to format the output; I'm going to close this PR for the time being. If anyone has a solution please feel free to reopen it! |
|
I'm reopening the issue so it's more visible to people who'd like to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request wraps the module
fitcircle.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version