Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pygmt.blockm*: Reorder input parameters to 'data, x, y, z' #1565

Merged
merged 1 commit into from
Oct 4, 2021
Merged

pygmt.blockm*: Reorder input parameters to 'data, x, y, z' #1565

merged 1 commit into from
Oct 4, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 3, 2021 •
edited by weiji14
Loading

Description of proposed changes

Fixes #1479.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.5.0 milestone Oct 3, 2021
@seisman seisman added the deprecation Deprecating a feature label Oct 3, 2021
@seisman seisman mentioned this pull request Oct 3, 2021
Closed
@weiji14 weiji14 added this to To do in Release v0.5.x via automation Oct 4, 2021
@seisman seisman merged commit a933364 into main Oct 4, 2021
@seisman seisman deleted the reorder-blockm-parameter branch October 4, 2021 09:03
Release v0.5.x automation moved this from To do to Done Oct 4, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
pygmt.blockm*: Reorder input parameters to 'data, x, y, z' (GenericMa…
0257f2c 
…ppingTools#1565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
deprecation Deprecating a feature
Projects
No open projects
Release v0.5.x
  
Done
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Standardize parameter name for table data inputs
2 participants
@seisman @weiji14