Allow GMTDataArrayAccessor to work on sliced datacubes #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `grdinfo` can't read the source NetCDF file as it is an n-dimensional datacube (instead of a 2D grid), we fallback to setting the default gridline registration and Cartesian grid type.
weiji14
force-pushed
the
accessor/sliced_datacube_bugfix
branch
from
684315d
to
95f28fc
Compare
So that the file can be deleted on Windows.
| @@ -34,7 +34,7 @@ def __init__(self, xarray_obj): | |||
| self._registration, self._gtype = map( | |||
| int, grdinfo(self._source, per_column="n", o="10,11").split() | |||
| ) | |||
| except KeyError: | |||
| except (KeyError, ValueError): | |||
There was a problem hiding this comment.
As I understand it, previous imports of sliced datacubes would result in a ValueError, so this makes an exception for it and sets the grid registration and type to a default?
There was a problem hiding this comment.
Correct. Sliced datacubes will fallback to using the default grid registration and type instead of raising a ValueError.
willschlitzer
approved these changes
Oct 27, 2021
willschlitzer
added
the
final review call
seisman
approved these changes
Oct 28, 2021
Comment on lines
+82
to
+85
| fname = which( | ||
| "https://github.com/pydata/xarray-data/raw/master/eraint_uvz.nc", | ||
| download="u", | ||
| ) |
There was a problem hiding this comment.
Do we want to cache this file in CI?
There was a problem hiding this comment.
Probably don't need to, since this file is on GitHub, and our CI is on GitHub too, so if GitHub is down, nothing will work 😆
michaelgrund
approved these changes
Oct 28, 2021
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…gTools#1581) If `grdinfo` can't read the source NetCDF file as it is an n-dimensional datacube (instead of a 2D grid), we fallback to setting the default gridline registration and Cartesian grid type. * Use with statement to ensure the grid is properly closed So that the file can be deleted on Windows. Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
If
grdinfocan't read the source NetCDF file as it is an n-dimensional datacube (instead of a 2D grid), we fallback to setting the default gridline registration and Cartesian grid type.Note that a warning like
grdinfo [WARNING]: Detected a data cube (eraint_uvz.nc) but -Q not set - skippingwill still be emitted, but runninggrid.gmt.registrationshould still work. Perhaps a better way would be to try to usegrdinfo -Q, but then we would somehow need to know which variable within the datacube people have sliced.Fixes #1578, Addresses #524 (comment)
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version