Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29: Set minimum required version to NumPy 1.19+ #1675

Merged
merged 7 commits into from
Dec 20, 2021
Merged

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Dec 19, 2021

Description of proposed changes

Following NEP29 policy where NumPy 1.18 is to be dropped on or after Dec. 22, 2021 (in a minor version increment, i.e. for PyGMT v0.6.0). Bumps minimum supported NumPy version to 1.19 in the setup.py, requirements.txt and environment.yml files. Also update installation documentation and set CI tests to run on NumPy 1.19.

xref: #1430

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund changed the title Drop NumPy 1.18 on Dec. 22, 2021 WIP Drop NumPy 1.18 on Dec. 22, 2021 Dec 19, 2021
@michaelgrund michaelgrund added the deprecation Deprecating a feature label Dec 19, 2021
@michaelgrund michaelgrund added this to the 0.6.0 milestone Dec 19, 2021
@michaelgrund michaelgrund changed the title WIP Drop NumPy 1.18 on Dec. 22, 2021 Drop NumPy 1.18 on Dec. 22, 2021 Dec 19, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@michaelgrund Better to change the title to "NEP29: Set minimum required version to NumPy 1.19+" following previous PRs #1430, #1074

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 20, 2021
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.

@michaelgrund michaelgrund changed the title Drop NumPy 1.18 on Dec. 22, 2021 NEP29: Set minimum required version to NumPy 1.19+ Dec 20, 2021
@michaelgrund
Copy link
Member Author

Looks good to me.

@michaelgrund Better to change the title to "NEP29: Set minimum required version to NumPy 1.19+" following previous PRs #1430, #1074

Thanks 😉

@michaelgrund
Copy link
Member Author

Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.

Good to know, that needs to be done by an owner, correct @weiji14 ?

@weiji14
Copy link
Member

weiji14 commented Dec 20, 2021

Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.

Good to know, that needs to be done by an owner, correct @weiji14 ?

Yep, just someone with admin privileges. I've done it already. Should be good to merge once status checks all pass.

@michaelgrund
Copy link
Member Author

Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.

Good to know, that needs to be done by an owner, correct @weiji14 ?

Yep, just someone with admin privileges. I've done it already. Should be good to merge once status checks all pass.

Great, thanks 😉

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 20, 2021
@seisman seisman merged commit 3477ceb into main Dec 20, 2021
@seisman seisman deleted the nep29/drop-numpy1.18 branch December 20, 2021 09:00
@weiji14 weiji14 mentioned this pull request Jul 2, 2022
26 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants