Migrate pylint settings from .pylintrc to pyproject.toml #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
reviewed
Feb 15, 2022
Comment on lines
-505
to
-535
| [DESIGN] | ||
|
|
||
| # Maximum number of arguments for function / method. | ||
| max-args=10 | ||
|
|
||
| # Maximum number of attributes for a class (see R0902). | ||
| max-attributes=10 | ||
|
|
||
| # Maximum number of boolean expressions in an if statement (see R0916). | ||
| max-bool-expr=5 | ||
|
|
||
| # Maximum number of branch for function / method body. | ||
| max-branches=12 | ||
|
|
||
| # Maximum number of locals for function / method body. | ||
| max-locals=15 | ||
|
|
||
| # Maximum number of parents for a class (see R0901). | ||
| max-parents=7 | ||
|
|
||
| # Maximum number of public methods for a class (see R0904). | ||
| max-public-methods=20 | ||
|
|
||
| # Maximum number of return / yield for function / method body. | ||
| max-returns=6 | ||
|
|
||
| # Maximum number of statements in function / method body. | ||
| max-statements=50 | ||
|
|
||
| # Minimum number of public methods for a class (see R0903). | ||
| min-public-methods=2 |
There was a problem hiding this comment.
Do we want to keep any more of these design choices? I think the max-attributes=10 is also a non-default choice according to #484. Feel like there are a few of these we should keep too even though we don't encounter it often.
There was a problem hiding this comment.
The default max-attributes=7 works well for the current main branch. Perhaps we should only change these values when we have to.
weiji14
reviewed
Feb 15, 2022
|
Ping @weiji14 and @meghanrjones for review. |
weiji14
approved these changes
Feb 20, 2022
weiji14
added
the
final review call
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ingTools#1755) * Migrate pylint settings from .pylintrc to pyproject.toml * Disable import-error * Remove .pylintrc from MANIFEST.in * Remove .pylintrc from workflows * Set generated-members to pandas.* * Refactor test_hotspots to avoid E1101 error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Changes in this PR:
.pylintrcpyproject.tomlimport-outside-toplevelandattribute-defined-outside-initjobsto 0 so that pylint can use all available cores (the old value is 4).Fixes #1740.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version