Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to make sure the incols parameter works for pandas.DataFrame #1771

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 26, 2022

Description of proposed changes

Fixes #1440

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@github-actions
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_plot_dataframe_incols.png

Image diff(s)

Added images

  • pygmt/tests/baseline/test_plot_dataframe_incols.png

Modified images

Path Old New

Report last updated at commit 123a5e9

@seisman seisman added the maintenance Boring but important stuff for the core devs label Feb 26, 2022
@seisman seisman added this to the 0.6.0 milestone Feb 26, 2022
@seisman seisman mentioned this pull request Feb 26, 2022
31 tasks
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Feb 27, 2022
@seisman seisman merged commit c306352 into main Feb 27, 2022
@seisman seisman deleted the test-dataframe-incols branch February 27, 2022 14:55
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The incols parameter does not always work for pandas.DataFrame
2 participants