Figure.contour/plot/plot3d/rose: Remove parameter "columns", use "incols" instead #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modified the original deprecation test into a regression test for #1313
weiji14
changed the title
maxrjones
approved these changes
Mar 12, 2022
maxrjones
added
the
final review call
seisman
approved these changes
Mar 13, 2022
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ols" instead (GenericMappingTools#1806) * Figure.contour: Remove parameter "columns", use "incols" instead * Figure.plot: Remove parameter "columns", use "incols" instead * Figure.plot3d: Remove parameter "columns", use "incols" instead * Remove unused deprecate_parameter function * Figure.rose: Remove parameter "columns", use "incols" instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Remove the parameter "columns" in favour of "incols" from
Figure.contour,Figure.plot,Figure.plot3dandFigure.rose. Deprecation warning was added in v0.4.0 (xref #1303, #1298, #1040, #1306), and is to be fully removed in v0.6.0.Note that there was a regression test for
fig.contour(..., incols=[1, 0, 2])that I've kept (xref #1313).Part of #1801.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version