Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pathlib support for plot and plot3d #1831

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Fix pathlib support for plot and plot3d #1831

merged 3 commits into from
Apr 5, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 18, 2022

Description of proposed changes

Minimal example to reproduce the issue:

import pygmt
from pathlib import Path

fig = pygmt.Figure()
fig.plot(data=Path("abc.txt"))
fig.show()

Error messages:

Traceback (most recent call last):
  File "/Users/user/pygmt/issues/plot-pathlib/test.py", line 5, in <module>
    fig.plot(data=Path("abc.txt"))
  File "/Users/user/pygmt/pygmt/helpers/decorators.py", line 872, in new_module
    return module_func(*args, **kwargs)
  File "/Users/user/pygmt/pygmt/helpers/decorators.py", line 585, in new_module
    return module_func(*args, **kwargs)
  File "/Users/user/pygmt/pygmt/helpers/decorators.py", line 725, in new_module
    return module_func(*args, **kwargs)
  File "/Users/user/pygmt/pygmt/src/plot.py", line 229, in plot
    elif "S" not in kwargs and kind == "file" and data.endswith(".gmt"):
AttributeError: 'PosixPath' object has no attribute 'endswith'

This PR fixes the bug.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the bug Something isn't working label Mar 18, 2022
@seisman seisman added this to the 0.6.1 milestone Mar 18, 2022
@seisman seisman marked this pull request as draft March 18, 2022 13:59
@seisman seisman marked this pull request as ready for review April 4, 2022 07:29
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Apr 4, 2022
@seisman seisman merged commit 32063b4 into main Apr 5, 2022
@seisman seisman deleted the fixplot-pathlib branch April 5, 2022 10:28
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 5, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants