Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basemap: Plotting frames if required parameters are not given #1909

Merged
merged 3 commits into from
Apr 30, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 27, 2022

Description of proposed changes

When required parameters are not given, basemap should set frame=True by default.

Implement the feature request in #1665 (comment).

Fixes #1665.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the feature request New feature wanted label Apr 27, 2022
@seisman seisman added this to the 0.7.0 milestone Apr 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2022

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_basemap_required_args.png

Image diff(s)

Added images

  • pygmt/tests/baseline/test_basemap_required_args.png

Modified images

Path Old New

Report last updated at commit 8232f85

@seisman seisman requested a review from a team April 29, 2022 03:34
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the minor typo the PR looks good to me!

pygmt/tests/test_basemap.py Outdated Show resolved Hide resolved
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 29, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 30, 2022
@seisman seisman merged commit c274463 into main Apr 30, 2022
@seisman seisman deleted the basemap-default-frame branch April 30, 2022 05:07
@weiji14 weiji14 added enhancement Improving an existing feature and removed feature request New feature wanted labels Jun 13, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…cMappingTools#1909)

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting frame=None gives unexpected results
3 participants