Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure.wiggle: Remove parameter 'columns', use 'incols' instead. #1977

Merged
merged 4 commits into from
Jun 24, 2022
Merged

Figure.wiggle: Remove parameter 'columns', use 'incols' instead. #1977

merged 4 commits into from
Jun 24, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 23, 2022 •
edited
Loading

Description of proposed changes

Related to #1966.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the deprecation Deprecating a feature label Jun 23, 2022
@seisman seisman added this to the 0.7.0 milestone Jun 23, 2022
weiji14
weiji14 reviewed Jun 23, 2022
View reviewed changes
pygmt/tests/test_wiggle.py Outdated Show resolved Hide resolved
pygmt/tests/test_wiggle.py Show resolved Hide resolved
@seisman @weiji14
Update pygmt/tests/test_wiggle.py
8abd4eb 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Jun 24, 2022
@seisman seisman merged commit 37ab418 into main Jun 24, 2022
@seisman seisman deleted the wiggle-deprecate branch June 24, 2022 04:23
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 24, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman @weiji14
Figure.wiggle: Remove parameter 'columns', use 'incols' instead. (Gen…
7ee300d 
…ericMappingTools#1977)

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
deprecation Deprecating a feature
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seisman @weiji14