Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure.ternary: Add parameters alabel, blabel, and clabel #2139

Merged
merged 16 commits into from
Oct 5, 2022
Merged

Figure.ternary: Add parameters alabel, blabel, and clabel #2139

merged 16 commits into from
Oct 5, 2022

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

This PR adds an alias for the missing -L flag in ternary.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Sep 25, 2022
@michaelgrund michaelgrund added this to the 0.8.0 milestone Sep 25, 2022
seisman
seisman reviewed Sep 26, 2022
View reviewed changes
pygmt/src/ternary.py Outdated Show resolved Hide resolved
@michaelgrund michaelgrund changed the title Add L alias for ternary.py Add L alias (alabel, blabel, clabel) for ternary.py Oct 2, 2022
seisman
seisman reviewed Oct 2, 2022
View reviewed changes
pygmt/src/ternary.py Outdated Show resolved Hide resolved
pygmt/src/ternary.py Outdated Show resolved Hide resolved
michaelgrund and others added 2 commits October 2, 2022 15:13
@michaelgrund @seisman
Apply suggestions from code review
084db36 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@michaelgrund
updates based on code review
84154eb
@michaelgrund
Copy link
Member Author

/format

seisman
seisman reviewed Oct 2, 2022
View reviewed changes
pygmt/src/ternary.py Outdated Show resolved Hide resolved
seisman
seisman approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removed two blank lines then this PR looks good to me.

pygmt/src/ternary.py Outdated Show resolved Hide resolved
pygmt/src/ternary.py Outdated Show resolved Hide resolved
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 3, 2022
@michaelgrund @seisman
Apply suggestions from code review
3aadc04 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
weiji14 reviewed Oct 3, 2022
View reviewed changes
pygmt/src/ternary.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022 •
edited
Loading

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_ternary_1_label.png
added pygmt/tests/baseline/test_ternary_3_labels.png

Image diff(s)

Added images

  • pygmt/tests/baseline/test_ternary_1_label.png

  • pygmt/tests/baseline/test_ternary_3_labels.png

Modified images

Path Old New

Report last updated at commit 6faa969

weiji14
weiji14 reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful now, need to delete the PNG images commited to the baseline/ folder.

@michaelgrund
Copy link
Member Author

Careful now, need to delete the PNG images commited to the baseline/ folder.

Done!

weiji14
weiji14 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @michaelgrund!

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 5, 2022
@seisman seisman changed the title Add L alias (alabel, blabel, clabel) for ternary.py Figure.ternary: Add parameters alabel, blabel, and clabel Oct 5, 2022
@seisman seisman merged commit 42208f0 into main Oct 5, 2022
@seisman seisman deleted the ternary-add-label branch October 5, 2022 15:45
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@michaelgrund @seisman @actions-bot
Figure.ternary: Add parameters alabel, blabel, and clabel (GenericMap…
6c07f04 
…pingTools#2139)

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
@weiji14 weiji14 added enhancement Improving an existing feature and removed documentation Improvements or additions to documentation labels Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

@weiji14 weiji14 weiji14 approved these changes

@willschlitzer willschlitzer Awaiting requested review from willschlitzer

Assignees
No one assigned
Labels
enhancement Improving an existing feature
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michaelgrund @seisman @weiji14 @willschlitzer @actions-bot