load_earth_relief: Add the support of data source 'synbath' #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't cached the new gridfiles yet; I'll add them later to |
willschlitzer
changed the title
|
I think you need to cache the |
seisman
reviewed
Nov 18, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
added
the
final review call
seisman
approved these changes
Nov 18, 2022
|
I combined the SYNBATH 01d grid test with the IGPP test. Happy to split it back into two tests, but I think this is easier since that have the same shape and min/max values. |
seisman
approved these changes
Nov 19, 2022
|
Since the PR title will be shown in the changelogs, what about changing the PR title to "load_earth_relief: Add the support of data source 'synbath'"? |
willschlitzer
changed the title
|
Ping @GenericMappingTools/pygmt-maintainers for final reviews. |
michaelgrund
approved these changes
Nov 21, 2022
willschlitzer
removed
the
final review call
10 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…appingTools#2162) * Add synbath option to earth_relief.py * Add tests for Earth relief with the synbath dataset * Update cache for synbath grids Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the synbath data source to
load_earth_reliefAddresses #1786
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version