load_earth_magnetic_anomaly: Add mag4km parameter to support earth_mag4km dataset #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Dec 9, 2022
seisman
reviewed
Dec 9, 2022
Comment on lines
34
to
36
| data = load_earth_magnetic_anomaly( | ||
| resolution="01d", registration="gridline", mag4km=False | ||
| ) |
There was a problem hiding this comment.
I prefer the old test without mag4km=False, because it also checks if the default dataset type (i.e., earth_mag) is changed.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
willschlitzer
changed the title
seisman
changed the title
seisman
reviewed
Dec 9, 2022
seisman
reviewed
Dec 11, 2022
Comment on lines
55
to
59
| Specifies using the observations at sea level only over oceanic | ||
| regions or over land and water at an altitude of 4 kilometers. The | ||
| default is ``False``, which uses an *earth_mag_type* of **earth_mag**\. | ||
| Setting ``mag4km`` to ``True`` sets the *earth_mag_type* | ||
| of **earth_mag4km**. The oceanic files are ~60% smaller. |
There was a problem hiding this comment.
I feel the description is a little difficult to understand. Maybe rewrite it to something like:
Choose the data version to use. The default is
False, which is observed at sea level over oceanic regions and have no data over land. Settingmag4kmtoTrueto use a version where all observations are relative to an altitude of 4 km above the geoid and includes data over land.
…maly-4km' into load-remote-dataset/magnetic-anomaly-4km
seisman
approved these changes
Dec 12, 2022
seisman
added
the
final review call
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
willschlitzer
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…g4km dataset (GenericMappingTools#2239) * Add mag4km parameter to load_earth_magnetic_anomaly.py * Add tests for mag4km and associated cache files * Add test_earth_mag_incorrect_resolution_registration function * Remove unnecessary file suffix from cache .grd files used by test_datasets_earth_magnetic_anomaly.py Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in this comment, this adds the
mag4kmoption for the magnetic anomaly dataset.Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version