Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated load_fractures_compilation function (deprecated since v0.6.0) #2303

Merged
merged 15 commits into from Jan 9, 2023
Merged

Remove the deprecated load_fractures_compilation function (deprecated since v0.6.0) #2303

merged 15 commits into from Jan 9, 2023

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Related to #2302

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the deprecation Deprecating a feature label Jan 4, 2023
@michaelgrund michaelgrund added this to the 0.9.0 milestone Jan 4, 2023
@michaelgrund michaelgrund mentioned this pull request Jan 4, 2023
Closed
7 tasks
@michaelgrund
Copy link
Member Author

/format

@michaelgrund @willschlitzer
Apply suggestions from code review
1238a26 
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
@michaelgrund michaelgrund self-assigned this Jan 4, 2023
@yvonnefroehlich yvonnefroehlich mentioned this pull request Jan 5, 2023
Merged
7 tasks
@michaelgrund
Copy link
Member Author

/format

@michaelgrund michaelgrund added the needs review This PR has higher priority and needs review. label Jan 6, 2023
seisman
seisman reviewed Jan 6, 2023
View reviewed changes
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
@michaelgrund
Copy link
Member Author

/format

seisman
seisman approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 9, 2023
@michaelgrund michaelgrund merged commit a7d96b4 into main Jan 9, 2023
@michaelgrund michaelgrund deleted the deprecate-load_fractures_compilation branch January 9, 2023 09:13
@michaelgrund michaelgrund removed the final review call This PR requires final review and approval from a second reviewer label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willschlitzer willschlitzer willschlitzer left review comments

@seisman seisman seisman approved these changes

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

Assignees

@michaelgrund michaelgrund

Labels
deprecation Deprecating a feature
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michaelgrund @seisman @willschlitzer @yvonnefroehlich @actions-bot