Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygmt.grdtrack: Remove the warning about the incorrect parameter order of 'points, grid' (warned since v0.7.0) #2312

Merged
merged 3 commits into from Jan 9, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 7, 2023

Description of proposed changes

In PR #1867, we changed the parameter order from "points, grid" to "grid, points", and raises a warning about incorrect parameter order. The PR first appeared in v0.7.0 and is expected to be removed in v0.9.0.

This PR removes the warning.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the deprecation Deprecating a feature label Jan 7, 2023
@seisman seisman added this to the 0.9.0 milestone Jan 7, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Jan 7, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 8, 2023
@seisman seisman merged commit 077a9a7 into main Jan 9, 2023
@seisman seisman deleted the grdtrack-warning branch January 9, 2023 05:17
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants