Add a gallery example showing how to use advanced grdgradient via the "azimuth" & "normalize" parameters #2354

jhtong33 · 2023-02-08T06:07:54Z

Description of proposed changes
This PR aims to add a gallery example showing how to use advanced grdgradient via the azimuth & normalize parameters

Because the gallery/images/grdgradient.py already showed how to use radiance parameter, I choose azimuth as the example.

Preview at https://pygmt-dev--2354.org.readthedocs.build/en/2354/gallery/images/grdgradient_shading.html

Fixes #2322

Reminders

Run make format and make check to make sure the code follows the style guide.
Add tests for new features or tests that would have caught the bug that you're fixing.
Add new public functions/methods/classes to doc/api/index.rst.
Write detailed docstrings for all functions/methods.
If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
If adding new functionality, add an example to docstrings or tutorials.
Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

/format: automatically format and lint the code
/test-gmt-dev: run full tests on the latest GMT development version

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

weiji14

Thanks @JingHuiTong! Just a few more comments/suggestions. It'll be good to include this in the upcoming PyGMT v0.9.0 release by the end of March, so we'll make sure to get this merged before then!

examples/gallery/images/grdgradient_shading.py

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

examples/gallery/images/grdgradient_shading.py

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

weiji14

Still need to fix the Style Checks (run \format), but this looks ready for final review!

examples/gallery/images/grdgradient_shading.py

Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

jhtong33 · 2023-03-15T01:59:09Z

/format

seisman

Looks great. Thanks for the nice gallery example @JingHuiTong.

examples/gallery/images/grdgradient_shading.py

yvonnefroehlich

Looks good to me!
Thanks @JingHuiTong for putting efforts into contributing this gallery example 🙂 and also for considering the review comments!

seisman · 2023-03-15T11:29:25Z

@JingHuiTong As mentioned in #2321 (comment), if you like, you can open a new pull request to add yourself to the AUTHORS.md file.

jhtong33 · 2023-03-16T02:25:02Z

@JingHuiTong As mentioned in #2321 (comment), if you like, you can open a new pull request to add yourself to the AUTHORS.md file.

WOW! Undoubtedly YES! I have already open new PR #2430

jhtong33 and others added 30 commits January 11, 2023 12:44

alias surface.py T=tensor

9007170

surface.py add tension documnets

4b62f0e

surface add -L -M -C:

803a278

Apply suggestions from code review

fc0ba08

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

surface add document: limit upper & lower

fbe59e2

Apply suggestions from code review

6cf98c8

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

Apply suggestions from code review

f917d9d

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

/format

add6d0a

format

5c77c5f

format bold and space

ae90cc3

Apply suggestions from code review

9d19405

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

Apply suggestions from code review

38e80c0

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

add Unit links

68f7fbf

add Unit links with :

78f721c

add Unit links

15680a7

Merge branch 'GenericMappingTools:main' into main

d05a7a5

adding grdgradient_shading

c6fcf49

[format-command] fixes

bffc4c2

Apply suggestions from code review

8c9505a

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

code finish

e5f5c54

Merge branch 'GenericMappingTools:main' into mini_branch

1fdc625

Merge branch 'main' into main

2897d2f

Apply suggestions from code review

3256f2b

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

add tension more infomation

2d433b0

Merge branch 'main' of github.com:JingHuiTong/pygmt into main

1492de9

mini_branch/ surface.py T=tension more information

3c8fd2c

Fix conflicts

968bda3

Merge remote-tracking branch 'origin/main' into main

6136b8a

[format-command] fixes

5653ef1

Apply suggestions from code review

8da18ee

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

Update examples/gallery/images/grdgradient_shading.py

384fba6

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

weiji14 reviewed Mar 8, 2023

View reviewed changes

jhtong33 and others added 2 commits March 14, 2023 11:33

Apply suggestions from code review

fd750d7

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

Add colorbar and change the light direction

bf4de7b

seisman reviewed Mar 14, 2023

View reviewed changes

examples/gallery/images/grdgradient_shading.py Outdated Show resolved Hide resolved

yvonnefroehlich reviewed Mar 14, 2023

View reviewed changes

Apply suggestions from code review

ad689a7

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

weiji14 approved these changes Mar 14, 2023

View reviewed changes

weiji14 added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 14, 2023

yvonnefroehlich reviewed Mar 14, 2023

View reviewed changes

examples/gallery/images/grdgradient_shading.py Outdated Show resolved Hide resolved

examples/gallery/images/grdgradient_shading.py Outdated Show resolved Hide resolved

examples/gallery/images/grdgradient_shading.py Outdated Show resolved Hide resolved

maxrjones mentioned this pull request Mar 14, 2023

Release PyGMT v0.9.0 #2424

Closed

36 tasks

seisman reviewed Mar 15, 2023

View reviewed changes

examples/gallery/images/grdgradient_shading.py Outdated Show resolved Hide resolved

JingHuiTong and others added 2 commits March 15, 2023 09:23

projection size

7d420ad

Apply suggestions from code review

4cb2dbe

Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>

actions-bot and others added 2 commits March 15, 2023 02:00

[format-command] fixes

f89a0c9

colorbar position -> middle

3a82b44

seisman approved these changes Mar 15, 2023

View reviewed changes

seisman reviewed Mar 15, 2023

View reviewed changes

examples/gallery/images/grdgradient_shading.py Show resolved Hide resolved

Merge branch 'main' into grdgradient

635512f

michaelgrund approved these changes Mar 15, 2023

View reviewed changes

yvonnefroehlich approved these changes Mar 15, 2023

View reviewed changes

seisman mentioned this pull request Mar 15, 2023

Colorbar positioning is problematic in subplot mode #2426

Closed

seisman merged commit 139c97e into GenericMappingTools:main Mar 15, 2023
5 checks passed

seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 15, 2023

seisman mentioned this pull request Mar 15, 2023

Figure.subplot: Fix strange positioning issues after exiting subplot #2427

Merged

11 tasks

jhtong33 deleted the grdgradient branch July 18, 2023 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a gallery example showing how to use advanced grdgradient via the "azimuth" & "normalize" parameters #2354

Add a gallery example showing how to use advanced grdgradient via the "azimuth" & "normalize" parameters #2354

jhtong33 commented Feb 8, 2023 •

edited by weiji14

weiji14 left a comment

weiji14 left a comment

jhtong33 commented Mar 15, 2023

seisman left a comment •

edited

yvonnefroehlich left a comment

seisman commented Mar 15, 2023

jhtong33 commented Mar 16, 2023

Add a gallery example showing how to use advanced grdgradient via the "azimuth" & "normalize" parameters #2354

Add a gallery example showing how to use advanced grdgradient via the "azimuth" & "normalize" parameters #2354

Conversation

jhtong33 commented Feb 8, 2023 • edited by weiji14

weiji14 left a comment

Choose a reason for hiding this comment

weiji14 left a comment

Choose a reason for hiding this comment

jhtong33 commented Mar 15, 2023

seisman left a comment • edited

Choose a reason for hiding this comment

yvonnefroehlich left a comment

Choose a reason for hiding this comment

seisman commented Mar 15, 2023

jhtong33 commented Mar 16, 2023

jhtong33 commented Feb 8, 2023 •

edited by weiji14

seisman left a comment •

edited