Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline example for grdview #2381

Merged
merged 9 commits into from Mar 23, 2023
Merged

Add inline example for grdview #2381

merged 9 commits into from Mar 23, 2023

Conversation

willschlitzer
Copy link
Contributor

Addresses #1957

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Feb 22, 2023
@willschlitzer willschlitzer added this to the 0.9.0 milestone Feb 22, 2023
@willschlitzer willschlitzer self-assigned this Feb 22, 2023
pygmt/src/grdview.py Outdated Show resolved Hide resolved
pygmt/src/grdview.py Outdated Show resolved Hide resolved
pygmt/src/grdview.py Outdated Show resolved Hide resolved
@maxrjones maxrjones mentioned this pull request Mar 14, 2023
36 tasks
@seisman seisman removed the skip-changelog Skip adding Pull Request to changelog label Mar 15, 2023
@seisman
Copy link
Member

seisman commented Mar 16, 2023

Ping @willschlitzer to see if you have time to finish this PR before the v0.9.0 release.

Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman
Copy link
Member

seisman commented Mar 19, 2023

It's likely that Will is busy recently, so I'm taking over this PR to make sure that we can have it done before v0.9.0.

@seisman seisman added the needs review This PR has higher priority and needs review. label Mar 19, 2023
pygmt/src/grdview.py Outdated Show resolved Hide resolved
pygmt/src/grdview.py Outdated Show resolved Hide resolved
pygmt/src/grdview.py Outdated Show resolved Hide resolved
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@willschlitzer
Copy link
Contributor Author

Hey, sorry that I've been MIA; I should have time to work on things this week, but no problem with @seisman making changes/approving things.

pygmt/src/grdview.py Outdated Show resolved Hide resolved
@seisman
Copy link
Member

seisman commented Mar 20, 2023

Hey, sorry that I've been MIA; I should have time to work on things this week, but no problem with @seisman making changes/approving things.

Don't worry. Welcome back.

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 22, 2023
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Just wondering whether we should decide about starting comments with either upper-case letters or with lower-case letters, across all examples? I have a little preference towards upper-case letters, but I am also totally fine with the lower-case option 🙂.

@seisman
Copy link
Member

seisman commented Mar 23, 2023

Hm. Just wondering whether we should decide about starting comments with either upper-case letters or with lower-case letters, across all examples? I have a little preference towards upper-case letters, but I am also totally fine with the lower-case option slightly_smiling_face.

Either is fine to me.

@seisman seisman merged commit 818dfa5 into main Mar 23, 2023
15 checks passed
@seisman seisman deleted the inline-example/grdview branch March 23, 2023 02:39
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants