Revise the notes about registration and gtype of remote datasets #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
seisman
commented
Feb 28, 2023
weiji14
reviewed
Mar 17, 2023
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
reviewed
Mar 17, 2023
There was a problem hiding this comment.
@yvonnefroehlich and @michaelgrund, if the wording looks ok, can @seisman apply the changes to the other datasets/earth_*.py files?
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
|
@michaelgrund and @yvonnefroehlich Any comments on this PR? Or can it be approved? |
michaelgrund
approved these changes
Mar 21, 2023
yvonnefroehlich
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #2378 for context.
Preview: https://pygmt-dev--2384.org.readthedocs.build/en/2384/api/generated/pygmt.datasets.load_earth_age.html
Fixes #2378
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version